Checkedtextview check/uncheck after scroll Listview

Question

I'm developing checkedtextview in listvew using viewHolder and getview. To populate check/uncheck status binding from database is running well. But, if I check item and then scroll listview, it will back to uncheck.

here is my customAdapter code.

public class CustomAdapter extends ArrayAdapter<Model> {
private Activity activity;
int id;
String autoid;
ArrayList<Model> items;
DatabaseHelper dbhelper = new DatabaseHelper(getContext());

public CustomAdapter(Activity context, int resource, ArrayList<Model> obj) {
    super(context, resource, obj);

    this.activity = context;
    this.id = resource;
    this.items = obj;

    try {
        dbhelper.openDatabase();
    } catch (SQLException e) {
        e.printStackTrace();
    }
}



static class ViewHolder {
    protected CheckedTextView textView;
}

@Override
public View getView(int position, View convertView, ViewGroup parent) {
    ViewHolder vh = null;

    if (convertView == null) {

        LayoutInflater inflater = activity.getLayoutInflater();
        convertView = inflater.inflate(id, null);
        vh = new ViewHolder();
        convertView.setTag(vh);

        vh.textView = (CheckedTextView) convertView.findViewById(R.id.textbox1);

    }
    else
    {
        vh = (ViewHolder) convertView.getTag();

    }

    final Model item = items.get(position);
    String status = item.getStatus();

    final Model check = getItem(position);

    final ViewHolder finalVh = vh;

    vh.textView.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View v) {
            autoid = item.getAutoid();

            if (! finalVh.textView.isChecked()) {
                finalVh.textView.setChecked(true);
            }
            else
            {
                finalVh.textView.setChecked(false);
            }
        }
    });

    vh.textView.setText(item.getDate() +". "+item.getInfo());
    vh.textView.setChecked(Boolean.parseBoolean(status));

    return convertView;
}}

Thanks in advance.

score 2 · Accepted Answer · edited Nov 26 '16 at 12:43

2

Thats because your list(items) which you passed has the old value.When you change the check status,update it to the list(items) which is populated to the listview.On Scroll the list view will load them items again, where it is getting the old value.

vh.textView.setOnClickListener(new View.OnClickListener() {
    @Override
    public void onClick(View v) {
        autoid = item.getAutoid();

        if (! finalVh.textView.isChecked()) {
            finalVh.textView.setChecked(true);
            item.setStatus("true")
        } else {
            finalVh.textView.setChecked(false);
            item.setStatus("false");
        }
        items.set(position, item);
    }
});

edited Nov 26 '16 at 12:43

Vignesh Sundaramoorthy

1,827
1
25
38

answered Nov 26 '16 at 12:29

Arpan Sharma

2,142
11
22

super, so basically on scroll listview will load adapter or how? – imma hanitya Nov 26 '16 at 12:51
listview just loads the items which are on screen at a time. As you start scrolling it loads new items and looses the old ones.Then when we scroll back up it again loads the items from the list you provided to it – Arpan Sharma Nov 26 '16 at 12:54
Where does this line come from? `item.getAutoid();` – grantespo Nov 28 '16 at 20:20
that is related to the question asked..it has no relevance to the concept – Arpan Sharma Nov 29 '16 at 04:44

score 0 · Answer 2 · answered Nov 26 '16 at 12:42

This is because your ViewHolder is reused, in a ListView you do not have the same instance number ViewHolder and element in the list, You have approximately the number of item displayed.

To fix it you can store if an item was checked in boolean list (same size of your item list) and in your getView set your item to checked if the boolean at the same position is true.

Checkedtextview check/uncheck after scroll Listview

2 Answers2

Linked