How start an activity using Intent inside a inner static class?

Question

I have a static and inner class inside my Activityclass. I need to call an Activity using Intent(context,nameOfTheNewActivity.class) because I am trying to call an Intent when an item from a RecyclerView.ViewHolder is clicked. I had to Override the onClick to get the position of the item was clicked using getLayoutPosition() (this getLayoutPosition() worked fine).

Now when I try to use Intent I have the error:

Non-static method cannot be referenced by a static context.

I read another links from Stackoverflow like this. How do I call an Intent in this case of static context and inside an inner class, I.e, how do I get the context inside an inner class, and how do I solve the **fundamental ** error to do not call a non static class from an static class?

I tried the following before ask here:

Get the context from the View using v.context but I continue with the problem - and still calling a non static method from a static context.
"Static" startActivity(Intent) method?
Delete the word static form my inner class, but did not solve and the app crashes.

My code:

public class ActivityOne extends AppCompatActivity implements
GoogleApiClient.OnConnectionFailedListener {

    public static class MessageViewHolderOfFriend extends RecyclerView.ViewHolder {   public  MessageViewHolderOfFriend(View v) {
        super(v);
        v.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
                ;

                Intent intent = new Intent(v.getContext(),NewActivityToRun.class);
                startActivity(intent);//Error in this Line//
            }
        });
    }
}

check this example, it will definately help https://github.com/shanwu/SimpleListViewExample — shanwu, Nov 29 '16 at 05:45
pass the context to adapter. 1. You should keep your inner class static, that's good way to prevent memory leaks. — shanwu, Nov 29 '16 at 05:56

score 4 · Accepted Answer · edited May 23 '17 at 11:55

4

Try using the reference of the Activity.

ActivityOne.this.startActivity(intent);

If that doesn't work, then know that startActivity is a method of any Context.

class MessageViewHolderOfFriend extends RecyclerView.ViewHolder {

    private final Context context;

    public  MessageViewHolderOfFriend(View v) {
        super(v);
        context = v.getContext();

        v.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
                Intent intent = new Intent(context,NewActivityToRun.class);
                context.startActivity(intent);
            }
        });

    }

Ref. How to open a different activity on recyclerView item onclick

Regarding

delete the word static from my inner class, but did not solve and the app crashes

You probably were closer to the solution with the removal of static. The app actually built. The app crashing means you should read the logcat and implement the proper solution.

edited May 23 '17 at 11:55

Community

1
1

answered Nov 29 '16 at 03:19

OneCricketeer

179,855
19
132
245

`ActivityOne.this` would only work if the `MessageViewHolderOfFriend` class wasn't static. – 4castle Nov 29 '16 at 03:22
Which is why I followed up with "if that doesn't work". Is the ViewHolder class supposed to be static anyways? – OneCricketeer Nov 29 '16 at 03:23
The second solution of cricket_007 worked! 1: inside the static inner class : Create a private final Context context; 2. Inside the constructor of the static inner class, after call super(v), take the context with: contex=v.getContext(); 3. inside v.setOnClickListener(...){ Intent intent = new Intent(context,NewActivityToRun.class);// to open – Gustavomcls Nov 29 '16 at 13:51

score 1 · Answer 2 · answered Nov 29 '16 at 04:58

You need use the Context to start SecondActivity, when you are using context.startActivity(intent) and you should add intent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK) before startActivity(intent)

MainActivity.java :

public class MainActivity extends AppCompatActivity {

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    FloatingActionButton fab = (FloatingActionButton) findViewById(R.id.fab);
    fab.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View view) {
            // method 1:
            MyInnerClass innerClass = new MyInnerClass();
            innerClass.firstLauncher(MainActivity.this);

           // method 2:
           // MyInnerClass.secondLauncher(MainActivity.this);
        }
    });
}


static class MyInnerClass {

    /**
     * member method
     */
    private void firstLauncher(Context context) {
        Intent intent = new Intent(context, SecondActivity.class);
        intent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
        intent.putExtra("flag_activity", "I'm 1th");
        context.startActivity(intent);
    }

    /**
     * static method
     */
    private static void secondLauncher(Context context) {
        Intent intent = new Intent(context, SecondActivity.class);
        intent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
        intent.putExtra("flag_activity", "I'm 2th");
        context.startActivity(intent);
    }

}
}

SecondActivity.java :

public class SecondActivity extends Activity {

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.content_main);

    TextView textView = (TextView) findViewById(R.id.tv_msg);

    String msg = getIntent().getStringExtra("flag_activity");
    textView.setText(msg);
}
}

All the implements are in the ContextImpl.java file.

How start an activity using Intent inside a inner static class?

2 Answers2

Linked