Uncaught Error: Call to a member function fetchAll() on boolean

Question

index.php:

$db = new Db();
$param = [':name' => 'Alex'];
$data = $db->sql('select * from test where name = :name',$param)->query();
var_dump($data);

and get the error :

 Fatal error: Uncaught Error: Call to a member function fetchAll() on boolean

Db.php

   public function sql($sql,array $params = null)
    {   
        $sql = $this->connection->prepare($sql);

        if($params){
            foreach ($params as $key => $param) {
                $sql->bindParam($key, $param);
            }
        }

        $this->statement = $sql;
        return $this; 
    }


    public function query($type = 1)
    {
      $statement = $this->statement->execute();

      return ($type == 1) ? $statement->fetchAll(static::$DB_FETCH) : $statement->fetch(static::$DB_FETCH);
    }

If I running in the sql() method, execute() and fetch() the data inside it , it can truly get the data , but put the execute() and fetch() to the query() method, getting the error message, Any Idea? ;

`false` means that your query failed, use http://php.net/manual/en/pdostatement.errorinfo.php to see the error. — u_mulder, Dec 18 '16 at 08:10
@u_mulder I var_dump(statement) and got ture ./Applications/MAMP/htdocs/Test/Program/Component/Db.php:60:boolean true — Fan, Dec 18 '16 at 08:15
/Applications/MAMP/htdocs/Test/Program/Component/Db.php:61: array (size=3) 0 => string '00000' (length=5) 1 => null 2 => null — Fan, Dec 18 '16 at 08:25

score 2 · Accepted Answer · edited May 23 '17 at 12:13

2

There is an error in your code. In this line:

$statement = $this->statement->execute();

The execute() method is PDOStatement::execute. This is the signature:

public bool PDOStatement::execute ([ array $input_parameters ] )

Which means it returns boolean. Your mistake is you are trying to call fetchAll() on a boolean.

For more information about the error message, see this page.

edited May 23 '17 at 12:13

Community

1
1

answered Dec 18 '16 at 08:24

Rei

6,263
14
28

score 0 · Answer 2 · answered Dec 18 '16 at 08:01

0

Try this

 public function query($sql,array $params = null,$type = 1)
    {
      $sql = $this->connection->prepare($sql);

      if($params){
          foreach ($params as $key => $param) {
              $sql->bindParam($key, $param);
          }
      }

      $this->statement = $sql;

      $statement = $this->statement->execute();

      return ($type == 1) ? $statement->fetchAll(static::$DB_FETCH) : $statement->fetch(static::$DB_FETCH);
    }

And

$data = $db->query('select * from test where name = :name',$param);

answered Dec 18 '16 at 08:01

ashkufaraz

5,179
6
51
82

This case is good, but i still can not understand the wrong that I made. – Fan Dec 18 '16 at 08:05
it's better to return a statement. Makes your function WAY more flexible and useful – Your Common Sense Dec 18 '16 at 12:46

score 0 · Answer 3 · answered Jul 24 '21 at 14:03

$statement = $this->statement->execute();

Your code is returning a bool value. But your statement object is cotaining your processed data. By the way you have to get returned values from main statement via:

 $this->statement->fetchAll();

Regards.

Uncaught Error: Call to a member function fetchAll() on boolean

3 Answers3