Java - HttpServer not serving images

Question

I have a simple setup including a HttpServer with some context to load image and CSS files:

public class Server {
    private HttpServer httpServer;

    public Server(int port, String path, HttpHandler handler) {
        try {
            httpServer = HttpServer.create(new InetSocketAddress(port), 0);

            httpServer.createContext(path, handler);

            // load css files
            List<String> cssFiles = new ArrayList<String>();
            Files.walk(Paths.get("../css")).forEach(filePath -> {
                if (Files.isRegularFile(filePath)) {
                    cssFiles.add(filePath.getFileName().toString());
                }
            });
            for (String cssFile : cssFiles) {
                httpServer.createContext("/css/" + cssFile, new CssHandler(cssFile));
            }

            // load image files
            List<String> imgFiles = new ArrayList<String>();
            Files.walk(Paths.get("../images")).forEach(filePath -> {
                if (Files.isRegularFile(filePath)) {
                    imgFiles.add(filePath.getFileName().toString());
                }
            });
            for (String imgFile : imgFiles) {
                httpServer.createContext("/images/" + imgFile, new ImageHandler(imgFile));
            }

            httpServer.setExecutor(null);
        } catch (IOException e) {
            e.printStackTrace();
        }

    }

    public void start() {
        this.httpServer.start();
    }
}

In addition to that there is a css handler which works perfectly fine and and an image handler class, which serves images defined in html tags, BUT images which are included via css tag "background-image" cannot be loaded.. why?

ImageHandler:

class ImageHandler implements HttpHandler {
    private String img;

    public ImageHandler(String img) {
        this.img = img;
    }

    @Override
    public void handle(HttpExchange http) throws IOException {
        if (http.getRequestMethod().equals("GET")) {
            System.out.println("img transfered..." + img);
            try {
                StringBuilder contentBuilder = new StringBuilder();
                try {
                    BufferedReader in = new BufferedReader(new FileReader("../images/" + img));
                    String str;
                    while ((str = in.readLine()) != null) {
                        contentBuilder.append(str);
                    }
                    in.close();
                } catch (IOException e) {
                }
                String response = contentBuilder.toString();
                http.sendResponseHeaders(200, response.length());
                OutputStream os = http.getResponseBody();
                os.write(response.getBytes());
                os.flush();
                os.close();
            } catch (Exception ex) {
                ex.printStackTrace();
            }
        }
    }
}

Sooo,

this works:

<img src="images/example.png"/>

But this one doesn't work:

background-image: url("images/example.png");

Could anybody explain why and suggest how to solve this problem?

Probably because the url is relative to the CSS. [See this question.](http://stackoverflow.com/questions/940451/using-relative-url-in-css-file-what-location-is-it-relative-to) — xiaofeng.li, Dec 18 '16 at 23:10

score 0 · Answer 1 · answered Dec 18 '16 at 23:23

0

Since partial URLs are relative to the source of the style sheet, and your paths structure looks like this:

/images/example.png
/css/example.css

So image URLs in example.css should either be absolute (/images/example.png), or have the correct relative path (../images/example.png).

answered Dec 18 '16 at 23:23

xiaofeng.li

8,237
2
23
30

hey ye you are right, one more question, now my server serves tries to serve those images, but.. there are to many, how can i modify my server/handler to serve all images? – Creative crypter Dec 18 '16 at 23:33
So...you are not serving **all** of the images? Do you have subfolders in your image folder? – xiaofeng.li Dec 18 '16 at 23:40
Yeah a handler for each image file seems utterly inefficient. – xiaofeng.li Dec 18 '16 at 23:41
how can i serve image effieintly? – Creative crypter Dec 18 '16 at 23:46
Well, you can serve them use any existing HTTP server (Apache/Nginx) if that's an option. – xiaofeng.li Dec 18 '16 at 23:48

Java - HttpServer not serving images

1 Answers1