Possibly unhandled rejection in Angular 1.6

Question

I have a code with AngularJS:

service.doSomething()
  .then(function(result) {
      //do something with the result
  });

In AngularJS 1.5.9 when I have error in the .then() section like:

service.doSomething()
  .then(function(result) {
      var x = null;
      var y = x.y;
      //do something with the result
  });

I'm getting clear error message:

TypeError: Cannot read property 'y' of null

But in version 1.6 with the same code I'm getting a different error:

Possibly unhandled rejection: {} undefined

I know that this is related to this change, and the single solution is quite simple by adding .catch() block:

service.doSomething()
  .then(function(result) {
      var x = null;
      var y = x.y;
      //do something with the result
  })
  .catch(console.error);

Now I again have what I want:

TypeError: Cannot read property 'y' of null

But how to obtain the same result (more detailed error) for entire application without adding .catch() block in every single place?

I tested the suggested solution to disable this by adding:

$qProvider.errorOnUnhandledRejections(false);

But with this the situation is even worse - I do not have ANYTHING in the console! The error is swallowed somewhere and not logged at all. I'm not sure is it a problem with AngularJS 1.6 or with my configuration.

Do you have any ideas how to "restore" logging behavior from version 1.5.9?

EDIT:

Adding custom error handler:

.factory('$exceptionHandler', function($log) {
  return function(exception, cause) {
    $log.warn(exception, cause);
  };
})

does not help at all. In the error handler I already receive the "wrapped" error.

No idea about this. But I recently reverted my application from 1.6 to 1.5.x.. I was having lots of issues with 1.6. — Ved, Dec 22 '16 at 10:58
I'm about to revert as well, especially after seeing the answer below. I wasted two days on this nonsense. — Sharondio, Dec 22 '16 at 15:48

score 20 · Accepted Answer · edited Aug 14 '18 at 00:54

20

This has been fixed with fix($q): Add traceback to unhandled promise rejections -- Commit 316f60f and the fix is included in the v1.6.1 release.

edited Aug 14 '18 at 00:54

georgeawg

48,608
13
72
95

answered Dec 22 '16 at 12:28

gkalpak

47,844
8
105
118

Discussion on this also buried in an old, unrelated issue: https://github.com/angular/angular.js/issues/14631 – Sharondio Dec 22 '16 at 16:00
1

In 1.6.1, I was still getting this error, using ngResource and $promise, so I had to use: $qProvider.errorOnUnhandledRejections(false); – httpete Jan 03 '17 at 22:28
7

@httpete: OP asked how to get a more clear error, not how to suppress unhandled rejections (which is not a good idea imo). – gkalpak Jan 04 '17 at 07:49
3

Well, i am with 1.6.1 and i still get the error. Even if i do have an error callback. Problem is my callback need to return a rejected promise so the client knows the service have an error. Then Poof! $http(config).then( (response) => {...}, (error) => { return $q.reject(error); } ); – Rouche Jan 12 '17 at 18:53
1

If you don't handle a rejection, you get an error. That's how it works. (Note that each `then()` call returns a new promise.) – gkalpak Jan 12 '17 at 19:34
Well, this means i have to do same thing as @httpete, or its a no go sadly :(. We have an interceptor wich deals with unhandled promises so that we dont need to do the same code everywhere. – Rouche Jan 12 '17 at 19:42
I get this error when moving from 1.5 to 1.7, and I do not have any (explicit) promises in my code. It functions perfectly in 1.5, but throws that error 3 times on starting in 1.7 – Mawg says reinstate Monica Feb 26 '20 at 06:45

score 16 · Answer 2 · edited Jun 20 '22 at 07:05

First option simply is to hide this specific rejection error by setting errorOnUnhandledRejections in $qProvider configuration as suggested Cengkuru Michael:

app.config(['$qProvider', function ($qProvider) {
    $qProvider.errorOnUnhandledRejections(false);
}]);

BUT this will only switch off logging. The error itself will remain

The better solution in this case will be - handling a rejection with .catch() method:

service.doSomething()
    .then(function (response) {})
    .catch(function (err) {});

Useful Links:

score 9 · Answer 3 · answered Jan 09 '17 at 11:29

9

I fixed the same problem with version 1.6.1 by upgrading angular-ui-router to 0.3.2.

answered Jan 09 '17 at 11:29

Stephen C

91
2

0.4 fixes some bugs also. – Spock Jan 27 '17 at 15:23

score 8 · Answer 4 · answered Oct 18 '17 at 16:59

This information helped me to track down what (in my case) was creating the promise and not adding an error handler. I found it buried in the discussion of issue #2889 "Possibly unhandled rejection with Angular 1.5.9".

The gist, is, patch $q to cache a stack-trace on creating promises, such that it can be retrieved when the error is triggered.

To do it, insert this code to decorate $q somewhere near the top of your angular app:

// Decorate the $q service when app starts
app.decorator('$q', ["$delegate", function($delegate) {
  // Create a new promise object
  var promise = $delegate.when();

  // Access the `Promise` prototype (nonstandard, but works in Chrome)
  var proto = promise.__proto__;

  // Define a setter for `$$state` that creates a stacktrace 
  // (string) and assigns it as a property of the internal `$$state` object.
  Object.defineProperty(proto, '$$state', {
    enumerable: true,
    set: function(val) {
      val.stack = new Error().stack;
      this._$$state = val;
    },
    get: function() {
      return this._$$state;
    }
  });

  return $delegate;
}]);

Then search the angular code for the message "possibly unhandled rejection" and put a breakpoint on that line. When the breakpoint is reached, print out the value of toCheck.stack on the console, and you'll see something like this:

>> toCheck.stack
"set@http://localhost:8000/js/dual-site.js:18:19
Promise@http://localhost:8000/js/angular.js:17008:22
then@http://localhost:8000/js/angular.js:17016:20
catch@http://localhost:8000/js/angular.js:17026:14
SyncStrategy.prototype.send@http://localhost:8000/js/angular-state-machine.js:436:24
StateMachine/this.send@http://localhost:8000/js/angular-state-machine.js:235:16

The offending code is the frame calling angular's catch/then functions.

This should be the right answer, and this should be part of Angular. Thanks a lot!! — ZadrackSaria, Dec 15 '17 at 10:57

Rouche · Answer 5 · 2017-01-13T18:47:05.703

4

There is another case, adding a finally() handler to a promise generate the error: http://plnkr.co/edit/eT834BkIEooAMvrVcLDe

Because finally() creates a new promise and call the resolver on it. (Rejecting a 2nd one in a rejection case)

Ive put a fix in the plnkr but it doesn't look very good.

edited Jan 13 '17 at 18:47

answered Jan 13 '17 at 16:11

Rouche

254
2
8

score 3 · Answer 6 · answered Jan 18 '17 at 06:20

3

I got same unhandled rejection error when a rejected promise is not handled by angular-ui-router (ui-sref) using angular ver1.6.1 & This feature is enabled by default.

For anyone that wants a workaround (not recommended, though), you can globally silence unhandled promise rejections like this —

app.config(['$qProvider', function ($qProvider) { $qProvider.errorOnUnhandledRejections(false); }]);

answered Jan 18 '17 at 06:20

Yash Vekaria

2,285
24
24

6

It is not good solution. I tested it and in some situations this setting will hide the true error as well. – Piotr Pradzynski Jan 18 '17 at 06:25

score 1 · Answer 7 · answered Jul 16 '17 at 14:49

I have solved this error by adding a default value in the catch block like:

service.doSomething()
    .then(function(response) {
        var x = null;
        var y = x.y;
    }).catch(function(error) {
        var y = 0;
    });

(take in count that I am not an experienced angular developer)

score 0 · Answer 8 · answered Jan 05 '17 at 08:58

I have the problem even with version 1.6.1 in my httpErrorInterceptor, for one usecase my if my api return 404 i have to try another request with other data... so in this case i only reject the request and angular throw the unhandled rejection error...

I install 1.5.9 and now there is no more error !

score 0 · Answer 9 · edited May 23 '17 at 12:02

errorOnUnhandledRejections(false); was not a resolution for me.

You do indeed need to define an exception handler... however... wrap it in a timeout function: this will force the original exception/stack trace to be thrown.

To make the error show up as an error in the web console, as you originally intended:

ng.factory('$exceptionHandler', function($log) {
  return function(exception, cause) {
    // do some some stuff...
    setTimeout(function(){
      // throw the original exception (with correct line #'s etc)
      throw exception;
    })
  };
});

Heres the timeout trick: Why can I not throw inside a Promise.catch handler?

Possibly unhandled rejection in Angular 1.6

9 Answers9

Linked

Related