Waiting until a variable exists with typeof causes an infinite loop

Question

I need a function that waits until a variable comes into existence.

function wait(variable, callback) {
    if (typeof variable !== "undefined")
        callback();
    else
        setTimeout(function () {
            wait(variable, callback);
        }, 0)
}

Calling this function with the example code below causes an infinite loop.

var a;
wait(a, function(){console.log('success')});
setTimeout(function(){a=1}, 1000)

Why?

Variables are passed by value, not by reference, so you're just passing the current, undefined value in your `setTimeout`. — Barmar, Dec 26 '16 at 08:41
You're passing the value of `a`, which will always be `undefined` — haim770, Dec 26 '16 at 08:41

score 14 · Accepted Answer · edited May 23 '17 at 12:16

14

JavaScript is pass by value, so when you pass a to wait, you just pass the value undefined.

You can try passing a function for the wait condition instead:

var a;
console.log('started');
wait(function(){return a}, function(){console.log('success')});
setTimeout(function(){a=1}, 1000)

function wait(condition, callback) {
    if (typeof condition() !== "undefined") {
        callback();
    } else {
        setTimeout(function () {
            wait(condition, callback);
        }, 0)
    }
}

You could also extend this method to wait for more than just the variable existing, but for when it has a certain value or something.

If you use NPM and promises, there's a library that does this already: wait-until-promise. There may be others that use classical callbacks as well.

edited May 23 '17 at 12:16

Community

1
1

answered Dec 26 '16 at 08:41

Scimonster

32,893
9
77
89

I'd suggest putting the entire `typeof` check inside the condition – Bergi Dec 26 '16 at 13:36
1

I suggest that in the sentence after the snippet. – Scimonster Dec 26 '16 at 13:37
Thank you very much! I was stuck by 2 days trying to make promises work but I could make it work with your help! – Victor Tavares Aug 02 '21 at 17:46

score 0 · Answer 2 · answered Dec 26 '16 at 08:44

0

var a ;
function wait(callback) {
if (typeof a !== "undefined") callback();
else setTimeout(function () {
        wait(callback);
    }, 0)
}
wait(function(){console.log('success')});
setTimeout(function(){a=1},1000)

answered Dec 26 '16 at 08:44

Anil Talla

709
5
19

Waiting until a variable exists with typeof causes an infinite loop

2 Answers2