C# architecture inheritage override different signature?

Question

I have three classes: CookedItem : ConsomableItem : Item

Item implements this method:

protected void Initialize(string name,TypeItem type) {...}

ConsomableItem implements this method:

protected void Initialize(float duration,string name,TypeItem type) {...}

Now here is my problem. The correct method to call for CookedItem is ConsomableItem.Initialize().

Can I hide the method Item.Initialize()to only see the methodConsomableItem.Initialize()`?

I can't use override because the signatures are different.

Any suggestion?

No - `CookedItem` is a `ConsomableItem` and indirectly an `Item` so it has rights to both functions. — D Stanley, Jan 17 '17 at 19:42
I cannot use constructors because i'm using Unity but thanks for suggestion — CrymX, Jan 17 '17 at 20:27

score 2 · Answer 1 · edited May 23 '17 at 10:29

2

You are violating the third principal of the SOLID. The Liskov Substitution Principal. Have a look at here to understand what it is.

Basically you have built a wrong inheritance.

What you should be doing is to ICookable and IConsumable interfaces, as behaviours. Then you will have two different item class implementations(you may still abstract them in an abstract class).

edited May 23 '17 at 10:29

Community

1
1

answered Jan 17 '17 at 19:46

Tolga Evcimen

7,112
11
58
91

score 0 · Answer 2 · edited May 23 '17 at 12:02

0

In your class hierarchy Initialize methods are protected, so they won't be visible to classes that are not in this inheritance hierarchy, so it is up to you to design a better API for external clients.

As for hiding the methods inside the hierarchy, I don't think it's possible, even if the methods were virtual, compiler would not allow you to change access modifiers of the methods. To find out more about why it's disallowed, read here

In addition to breaking LSP as @Tolga Evcimen mentioned, it does not make a lot of sense to have this inheritance hierarchy. Inheritance is thought of as is-a relationship, now is CookedItem really an Item, if calling Initialize methods that belong to item do not make sense / yield inconsistent object state?

edited May 23 '17 at 12:02

Community

1
1

answered Jan 17 '17 at 19:42

ironstone13

3,325
18
24

1

OP wants to hide the function from `CookedItem` which inherits from `Item`. – D Stanley Jan 17 '17 at 19:43
@DStanley - I understand that, however, it is not possible - I've added an explanation why – ironstone13 Jan 17 '17 at 19:53

C# architecture inheritage override different signature?

2 Answers2