Recovering IP/Port from Socket Descriptor

Question

I'm writing a clone of inetd in which I must run a server that prints the IP and port of the client connecting to it.

As I overwrite STDIN and STDOUT with the socket descriptor, my initial solution to do this was to recover the sockaddr_in structure, which contains the needed information. Doing this with getsockname(), however, is returning an empty structure, with all bits set to 0.

Any idea of what is wrong with my approach? Are there any other approaches I can use to recover the IP/Port?

Thanks

score 11 · Accepted Answer · edited Mar 21 '12 at 22:33

11

As R.. pointed out, you should use getpeername. Both that function and getsockname take a file descriptor as its first argument, not a stream pointer (FILE *). Use fileno(stdin) to get the file descriptor for standard input (or hard-code it to STDIN_FILENO, as it's constant).

Also, the last argument to getsockname and getpeername should be a pointer to socklen_t, not a constant, and you should use a sockaddr_in for TCP/IP:

struct sockaddr_in peeraddr;
socklen_t peeraddrlen = sizeof(peeraddr);
getpeername(STDIN_FILENO, &peeraddr, &peeraddrlen);

See a complete example here.

edited Mar 21 '12 at 22:33

mmoya

1,901
1
21
30

answered Nov 15 '10 at 16:00

Fred Foo

355,277
75
744
836

OP mentioned "overwriting" stdin and stdout with the file descriptor for the socket, which is improperly worded at best, but it might indicate that the replacement is being done incorrectly and stdin (fd 0) is not actually a socket... – R.. GitHub STOP HELPING ICE Nov 15 '10 at 16:10
1

Dunno if this is *the* problem, but using `struct sockaddr` except as a really ugly substitute for `void *` is always a mistake. You should never have actual objects of type `struct sockaddr`. Always use `struct sockaddr_in`, `struct sockaddr_in6`, or `struct sockadd_storage`, as necessary. – R.. GitHub STOP HELPING ICE Nov 15 '10 at 16:42

R.. GitHub STOP HELPING ICE · Answer 2 · 2010-11-15T16:47:56.340

Use getpeername. I suspect your problem is that getsockname is returning the information for your own (local) side of the socket, which is probably bound to 0.0.0.0 (meaning it can accept connections from any interface).

Edit: I think I found your actual bug reading the code. This line is wrong:

getsockname(stdin, &addr, sizeof(addr));

The getsockname and getpeername functions take a socklen_t * (a pointer) as their third argument, not a size_t. The compiler should be telling you about this mistake unless you forgot to include a header with the prototype for getsockname. Also, as has already been said, stdin is incorrect. Try:

socklen_t len = sizeof addr;
getpeername(0, &addr, &len);

or (C99 only):

getpeername(0, &addr, (socklen_t[1]){sizeof addr});

You should also be checking the return value; if you did, you'd see that it's returning errors.

If you mean that getpeername() returns 0, it means that the function has been successful. — Simone, Nov 15 '10 at 16:00

score 2 · Answer 3 · answered Nov 15 '10 at 15:59

2

If you need those info for the remote client, you have to call getpeername().

answered Nov 15 '10 at 15:59

Simone

11,655
1
30
43

Recovering IP/Port from Socket Descriptor

3 Answers3

Linked