delete from table by itemid on procedure

Question

I created following procedure to remove item from allitems table by itemid, but procedure doesn't work as I wan,t. It Remove all items.

procedure DeleteItem(itemid in number) is
  begin
   delete from allitems where itemid=itemdid;
   commit;
  end;

Don't name your parameters the same as a column in the table. — , Feb 06 '17 at 09:22
As a general rule, [do not put a `COMMIT` statement in a procedure](http://stackoverflow.com/a/41998936/1509264). If the data needs `COMMIT`ing then it should be done from where the procedure is called allowing you to bundle multiple procedure calls into a single transaction and `COMMIT` or `ROLLBACK` them all in one go. — MT0, Feb 06 '17 at 11:18

score 0 · Answer 1 · answered Feb 06 '17 at 09:37

I know its not fashionable to have strict naming standards but they honestly help. Name your parameters prefixed with 'p_' so your code becomes;

create or replace procedure DeleteItem(itemid_in in number) is
begin
  delete from allitems where itemid = itemid_in;
  commit;  
end;

1 Answers1