writing to a text file

Question

I have a text file with these contents

balamurugan,rajendran,chendurpandian
christopher
updateba

and i have read these files and searched for a keyword ba and i tried to write in another text file log.txt but after executing my code i am getting the third line only as

`LineNo : 2 : updateba`

I need to get both these lines

LineNo : 0 : balamurugan,rajendran,chendurpandian
LineNo : 2 : updateba

I am using this code to write to a text file

if (File.Exists(FilePath))
        {
            // Read the file and display it line by line.
            System.IO.StreamReader file = new System.IO.StreamReader(FilePath);
            while ((line = file.ReadLine()) != null)
            {
                if (line.Contains(regMatch))
                {
                    DirectoryInfo Folder = new DirectoryInfo(textboxPath.Text);
                    if (Folder.Exists)
                    {
                        var dir = @"D:\New folder\log";
                        if (!Directory.Exists(dir))
                        {
                            Directory.CreateDirectory(dir);
                        }
                        File.WriteAllText(Path.Combine(dir, "log.txt"), "LineNo : " + counter.ToString() + " : " + line + "<br />");

                    }
                    else
                    {
                        Response.Write("<script language='javascript'>window.alert('Folder not found');</script>");
                    }
                    Response.Write("<script language='javascript'>window.alert('Pattern found');</script>");
                    Response.Write("LineNo : " + counter.ToString()+ " : " + line + "<br />");
                }

                else
                {
                    Response.Write("<script language='javascript'>window.alert('Pattern not found');</script>");
                }
                counter++;


            }
               file.Close();
        }
        else
        {
            Response.Write("<script language='javascript'>window.alert('File not found');</script>");
        }

i have used this samplelink text

Any suggestion???

it seams you're messing up with the Encoding. force Encoding to `Default` or `UTF-8` and you will stop having those problems — balexandre, Nov 22 '10 at 12:14

Marc Gravell · Accepted Answer · 2010-11-22T13:00:55.843

You are calling WriteAllText - this overwrites the file; perhaps you should File.AppendAllText? Or, more efficiently, use a StreamWriter in the first place - i.e.

using (var dest = File.CreateText(path))
{
    while (loopCondition)
    {
        // snip
        dest.WriteLine(nextLineToWrite);
    }
}

Reducing the code in the question to something like the minimal key code, something like:

DirectoryInfo Folder = new DirectoryInfo(textboxPath.Text);
var dir = @"D:\New folder\log";
if (Folder.Exists)
{                
    if (!Directory.Exists(dir)) Directory.CreateDirectory(dir);
}

if (File.Exists(FilePath))
{
    // Read the file and display it line by line.
    using (var file = File.OpenText(FilePath))
    using (var dest = File.AppendText(Path.Combine(dir, "log.txt")))
    {
        while ((line = file.ReadLine()) != null)
        {
            if (line.Contains(regMatch))
            {
                dest.WriteLine("LineNo : " + counter.ToString() + " : " +
                     line + "<br />");
            }
            counter++;
        }
    }
}

@Marc Gravell LineNo : 0 : balamurugan,rajendran,chendurpandian
LineNo : 2 : updateba
LineNo : 0 : balamurugan,rajendran,chendurpandian
LineNo : 2 : updateba — bala3569, Nov 22 '10 at 13:34
@Marc Gravell next time when i click submit button it is overwriting — bala3569, Nov 22 '10 at 13:35
@Marc Gravell i need to create a folder after giving the path in a textbox without giving the hardcore path in the code.. — bala3569, Nov 23 '10 at 12:28

score 1 · Answer 2 · answered Nov 22 '10 at 12:15

File.WriteAllText

Creates a new file, write the contents to the file, and then closes the file. If the target file already exists, it is overwritten.

Source. http://msdn.microsoft.com/en-us/library/system.io.file.writealltext.aspx

You probably want to make a buffer and write the buffer the file after you are done.

edit damn it 20 seconds too late.

score 0 · Answer 3 · answered Nov 22 '10 at 12:18

0

you need AppendAllText

answered Nov 22 '10 at 12:18

Bolu

8,696
4
38
70

writing to a text file

3 Answers3