function not return value php

Question

The following function does not return any value when if statement is true; otherwise it is returning $var1; it shows the correct value.

function setValue($var1) {
    global $con;
    global $k;
    $k++;
    $var1 = strtolower($var1);
    $var1 = preg_replace('/[^a-zA-Z0-9_-]/', '-', $var1);
    $var1 = preg_replace('/-+/', '-', $var1);
    $result1 = mysqli_query($con, "select * from tbl_name where name='".$var1."'");
    if (mysqli_num_rows($result1) > 0) {            
        setValue($var1.'-'.$k);
    }
    else {
        //die($var1);
        return $var1;
    }           
}

It is not returning because no return statement present for `true` condition. — Sougata Bose, Mar 14 '17 at 06:47
for `true` condition its a recursive cal, still i need to add return? — Asif, Mar 14 '17 at 06:52
@Mittul `print_r(setValue());` where should i put it? 'm getting correct value when i die inside else,but it is not returning — Asif, Mar 14 '17 at 06:56
@Asif you can put this anywhere where you able to call this function. — Mittul At TechnoBrave, Mar 14 '17 at 06:57

ReadyFreddy · Answer 1 · 2017-03-14T07:10:58.357

Edit: Sorry i didn't see it's recursive but seems like you are doing it wrong still. return and recursive like that is not a good idea. I think you should return values by this method and then use it in a loop by passing var and k parameters.

First of all you need to check your if statement. You are not returning any value if first condition is true, you are calling some method only.

if(mysqli_num_rows($result1)>0)
{           
    setValue($var1.'-'.$k);
    return($var1);
}
else
{
    "Give some error to user here";
     return($var1); //if you still want to see it...
}

It's better to inform user if "else" is true while you are checking DB works like that.

score 0 · Answer 2 · answered Mar 14 '17 at 07:03

0

change:

setValue($var1.'-'.$k);

to:

return ($var1.'-'.$k);

answered Mar 14 '17 at 07:03

Hossam

1,126
8
19

function not return value php

2 Answers2