I can`t enter values when I run my code

Question

void Manager::ManagerView1()
{
    system("cls");
    string Ipass;
    string Opass;
    ifstream Password("Password.txt", ios::in);
    if (!Password)
    {
        cerr << "Check File Integrity";
    }
    else
    {
        while (!Password.eof())
        {
            getline(Password,Ipass);
            cout << "Enter Password :\n";
            cin >> Opass;

            if (Opass == Ipass)
            {
                cout << "Passwords Match";
            }
        }
    }
}

Text inside the "Password.txt":

Abhik Ray 1123

The password is being read properly, I have already checked that.

When I run the code it lets me enter the password but then the Passwords match doesn't show up as it should. And then it again asks for the password where I am unable to enter it. And then it just quits.

What should I change?

Is "Abhik Ray 1123" the password, or is "Abhik Ray" the username and "1123" the password? — BusyProgrammer, Mar 26 '17 at 14:43
Ok but my main question is why am i unable to enter Opass for comparison . I mean i do need to enter it to compare but i can`t enter it in the first place. — Abhik Ray, Mar 26 '17 at 14:49

score 2 · Answer 1 · edited May 23 '17 at 12:25

You have several problems, like trying to match only one line from the password file at a time.

The reason for the message is that if (Opass == Ipass) compares the addresses of the character arrays, not their contents.

If you had used std::string to store the strings, the comparison would have worked, but with C style strings you need to use if(strcmp(Opass, Ipass) == 0).

You might also want to check this question for how to terminate the loop:

Why is iostream::eof inside a loop condition considered wrong?

In the new version of the code with cin >> Opass; the >> will only read one word at a time (it stops at each space). So if you type Abhik Ray 1123 you will only get Abhik in Opass, and the rest of the line will remain in the input buffer until the next read.

That's also why it doesn't ask for the next input, it just reads the following words that are already there.

To read a whole line of input, you need to use getline(cin, Opass);, just like when you read from the textfile.

I can`t enter Opass. How do i so that ?? – Abhik Ray Mar 26 '17 at 14:42 — Abhik Ray, Mar 26 '17 at 14:42

score 0 · Answer 2 · answered Mar 26 '17 at 14:35

0

Opass and Ipass are pointers and by doing Opass == Ipass you check if they point to the same area in the memory. You have to use strcmp to compare their values.

answered Mar 26 '17 at 14:35

OrMiz

265
2
11

well that`s okay but the main problem is that i can`t even enter Opass – Abhik Ray Mar 26 '17 at 14:40
did you try cin >> Opass? – OrMiz Mar 26 '17 at 14:43

I can`t enter values when I run my code

2 Answers2