php if{} elseif{} else{} syntax error

Question

pls help me with code i dont get where is the error

$userrole = $row['type'];

if ($userrole = "admin") {
        $_SESSION['name'] = $row['name'];
        header("Location: ../index.php"); 
} elseif ($userrole = "encoder") {
        $_SESSION['name'] = $row['name'];
        header("Location: ../mencode.php"); 
} elseif ($userrole = "verifier") {
        $_SESSION['name'] = $row['name'];
        header("Location: ../mverify.php"); 
} else ($userrole = "approver") {
        $_SESSION['name'] = $row['name'];
        header("Location: ../mapproved.php"); }

thnx in advance

`else` doesn’t take a condition. Also, single `=` is assignment; if you want to compare two values for equality, use `==` or `===`. — Ry-, Mar 27 '17 at 04:30

Sagar Bhut · Accepted Answer · 2017-03-27T04:36:21.917

0

replace in your code

   $userrole = $row['type'];

if ($userrole == "admin") {
        $_SESSION['name'] = $row['name'];
        header("Location: ../index.php"); 
} elseif ($userrole == "encoder") {
        $_SESSION['name'] = $row['name'];
        header("Location: ../mencode.php"); 
} elseif ($userrole == "verifier") {
        $_SESSION['name'] = $row['name'];
        header("Location: ../mverify.php"); 
} elseif ($userrole == "approver") {
        $_SESSION['name'] = $row['name'];
        header("Location: ../mapproved.php"); }

edited Mar 27 '17 at 04:36

answered Mar 27 '17 at 04:30

Sagar Bhut

657
6
28

thnx i use == for the if statement – marcie castillo Mar 27 '17 at 05:23
anser help so you can click (up arrow) in anser left side and after click right mark – Sagar Bhut Mar 27 '17 at 05:27

score 0 · Answer 2 · answered Mar 27 '17 at 04:32

You made the fundamental error of all new PHP developers:

if($a=$b) is an assignment statement. It sets $b to whatever is on the right.
if($a==$b) is a comparison statement. It compares two values without changing anything.

Change your statements to ($userrole=='…').

score 0 · Answer 3 · answered Mar 27 '17 at 04:38

Try this

$userrole = $row['type'];

if ($userrole == "admin") {
        $_SESSION['name'] = $row['name'];
        header("Location: ../index.php"); 

} elseif ($userrole == "encoder") {
        $_SESSION['name'] = $row['name'];
        header("Location: ../mencode.php"); 

} elseif ($userrole == "verifier") {
        $_SESSION['name'] = $row['name'];
        header("Location: ../mverify.php"); 

} else {
        $_SESSION['name'] = $row['name'];
        header("Location: ../mapproved.php"); }

Your if statements have to be comparison operators == and not assignment operators =.

Also elseis a catch all, so you don't provide it with comparison values like you would with if or else if. I am a c++ programmer, but I've done a little PHP.

php if{} elseif{} else{} syntax error

3 Answers3