Update listView after updating dataBase?

Question

I have a listView of books ,I update listview by clicking on item and its work , but i have duplicate item , the old one and the new one.in my database i have just the new data. How can i also modify my listview? I'm using FireBase Database.

Update with source of my activity:

public class ListOfMyBookActivity extends AppCompatActivity  {

//The elements are initialized here

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_list_of_my_book);

        listView = (ListView) findViewById(R.id.list_book);

        feedItems = new ArrayList<Book>();
        dataBD= FirebaseDatabase.getInstance();
        dataBaseD=FirebaseDatabase.getInstance();
        updateDB=FirebaseDatabase.getInstance();
        ref = dataBD.getReference("books");
        refdelete=dataBaseD.getReference("books");
        refUpdate=updateDB.getReference("books");
        auth = FirebaseAuth.getInstance();
        mDatabase = FirebaseDatabase.getInstance().getReference("books");


            ref.orderByChild("date_creation").limitToLast(10).addValueEventListener(new ValueEventListener() {
                @Override
                public void onDataChange(DataSnapshot dataSnapshot) {



                    List<String> list = new ArrayList<String>();
                    for (DataSnapshot dataSnap : dataSnapshot.getChildren()) {

                        Book valueBook = dataSnap.getValue(Book.class);
                        keyId = dataSnap.getKey();

                        String userBd = valueBook.getId_user();
                        if (userBd.equalsIgnoreCase(id_user)) {
                            String titreLivreToDisplay = valueBook.getNom_livre();
                            String descLivreToDisplay = valueBook.getDesc_livre();
                            String prixLivreToDisplay = valueBook.getPrix_livre();
                            String timeToDisplay = valueBook.getDate_creation();
                            String filePathToDiplay = valueBook.getChemin_image();
                            String villeToDisplay = valueBook.getVille_livre();
                            String typeAnnToDisplat = valueBook.getType_annonce_selected();
                            String bookid = valueBook.getId_book();



                            item = new Book();
                            item.setNom_livre(titreLivreToDisplay);
                            item.setDesc_livre(descLivreToDisplay);
                            item.setPrix_livre(prixLivreToDisplay);
                            item.setDate_creation(timeToDisplay);
                            item.setChemin_image(filePathToDiplay);
                            item.setVille_livre(villeToDisplay);
                            item.setType_annonce_selected(typeAnnToDisplat);
                            item.setId_book(bookid);
                            item.setKeyIdNode(keyId);

                            feedItems.add(item);


                        }

                        Collections.reverse(feedItems);


                        listAdapter = new MyBookListAdapter(ListOfMyBookActivity.this, feedItems);

                        listView.setAdapter(listAdapter);

                        listView.setOnItemClickListener(myClickListener);

                        listAdapter.notifyDataSetChanged();


                    }}



            });


    }


    public AdapterView.OnItemClickListener myClickListener = new AdapterView.OnItemClickListener() {

        @Override
        public void onItemClick(AdapterView<?> arg0, View arg1,
                                final int position, long arg3) {
            deleteItem = position;
            // The AlertDialog is created programmatically
            AlertDialog.Builder alert = new AlertDialog.Builder(arg1.getContext());

            nameBookEdtDlg.setText(nom);
            descBookEdtDlg.setText(desc);
            prixBookEdtDlg.setText(prix);

                alert.setPositiveButton("Update ",
                        new DialogInterface.OnClickListener()

                {
                    public void onClick (DialogInterface dialog,
                    int whichButton){


                    Query query = refUpdate.orderByChild("id_book").equalTo(bookID);

                    query.addListenerForSingleValueEvent(new ValueEventListener() {

                        @Override
                        public void onDataChange(DataSnapshot dataSnapshot) {

                            prixSt=prixBookEdtDlg.getText().toString();
                            descSt=descBookEdtDlg.getText().toString();
                            namSt=nameBookEdtDlg.getText().toString();


                            Map<String, Object> result = new HashMap<String, Object>();
                            result.put("nom_livre", namSt);
                            result.put("desc_livre", descSt);
                            result.put("prix_livre", prixSt);
                            result.put("date_creation", currentDateandTimeUpdate);
                            refUpdate.child(keyId).updateChildren(result);

                            listAdapter.notifyDataSetChanged();

                        } });

            AlertDialog alertDialog = alert.create();

                try{alertDialog.show();} } };}
                }

}

The Adapter :

public class MyBookListAdapter extends BaseAdapter {


    public MyBookListAdapter( ListOfMyBookActivity listMyBooks, List<Book> feedItemsBooks) {
        this.activity = listMyBooks;
        this.feedItemsBooks = feedItemsBooks;
    }
    @Override
    public int getCount() {
        return feedItemsBooks.size();
    }

    @Override
    public Object getItem(int location) {
        return feedItemsBooks.get(location);
    }

    @Override
    public long getItemId(int position) {
        return position;
    }

    @Override
    public View getView(int position, View convertView, final ViewGroup parent) {
        final int pos = position;

        if (inflater == null) {
            inflater = (LayoutInflater) activity
                    .getSystemService(Context.LAYOUT_INFLATER_SERVICE);
        }
        if (convertView == null) {
            convertView = inflater.inflate(R.layout.feed_list_item, null);

        }
        storageDisplayImg = FirebaseStorage.getInstance();
        auth = FirebaseAuth.getInstance();
        FirebaseUser userConnect = auth.getCurrentUser();
        String id_user = userConnect.getUid();
        mFirebaseInstance = FirebaseDatabase.getInstance();
        mFirebaseDatabase = mFirebaseInstance.getReference("books");


        final ImageView profilePic = (ImageView) convertView.findViewById(R.id.book_picture_display_myBook);
        name = (TextView) convertView.findViewById(R.id.name_book_display_myBook);
        TextView timestamp = (TextView) convertView.findViewById(R.id.timestamp_myBook);
        statusMsg = (TextView) convertView.findViewById(R.id.desc_display_myBook);
        prix = (TextView) convertView.findViewById(R.id.prix_display_myBook);
        TextView ville = (TextView) convertView.findViewById(R.id.ville_display_myBook);
        TextView typeCat = (TextView) convertView.findViewById(R.id.type_ann_to_display_myBook);


        Book item = feedItemsBooks.get(position);



        idLivreListAdapter=item.getId_book();

        name.setText(item.getNom_livre());

        if (!TextUtils.isEmpty(item.getDate_creation())) {
            timestamp.setText(item.getDate_creation());
            timestamp.setVisibility(View.VISIBLE);
        } else {
            timestamp.setVisibility(View.GONE);
        }

        if (!TextUtils.isEmpty(item.getDesc_livre())) {
            statusMsg.setText(item.getDesc_livre());
            statusMsg.setVisibility(View.VISIBLE);
        } else {
            statusMsg.setVisibility(View.GONE);
        }

        if (!TextUtils.isEmpty(item.getType_annonce_selected())) {
            typeCat.setText(item.getType_annonce_selected());
            typeCat.setVisibility(View.VISIBLE);
        } else {
            typeCat.setVisibility(View.GONE);
        }


        if (item.getPrix_livre() != null) {
            prix.setText(item.getPrix_livre() + " DH");
            prix.setVisibility(View.VISIBLE);
        } else {
            prix.setVisibility(View.GONE);
        }

        if (item.getVille_livre() != null) {

            ville.setText(item.getVille_livre());
            ville.setVisibility(View.VISIBLE);
        } else {
            ville.setVisibility(View.GONE);
        }

        storageRef = storageDisplayImg.getReferenceFromUrl(item.getChemin_image());
        Log.e(" ", " storageRef " + storageRef.toString());

        if (item.getChemin_image() != null && id_user != null) {


            Glide.with(convertView.getContext())
                    .using(new FirebaseImageLoader())
                    .load(storageRef)
                    .into(profilePic);
            profilePic.setVisibility(View.VISIBLE);

        } else {
            profilePic.setVisibility(View.GONE);
        }


        return convertView;
    }



}

My question is not duplicated I tried the proposed solutions but it does not work.

Use cursor adapter and chnageCursor(), Your can get example from https://github.com/codepath/android_guides/wiki/Populating-a-ListView-with-a-CursorAdapter — rajahsekar, Apr 17 '17 at 13:43
Try making a [mcve]. You've not defined `lidtAdapter` in the question. Youve also not visiblly modified the list in order for the notify method to do anything — OneCricketeer, Apr 17 '17 at 13:44
i agree with @rajahsekar use content providers and CursorLoader to know any change in database, and on loader finish you can notify data set changed — Ashwani, Apr 17 '17 at 13:45
arrayList.remove([INDEX]); then arrayAdapter.notifyDataSetChanged(); — Mukesh M, Apr 17 '17 at 13:51

score 2 · Answer 1 · answered Apr 17 '17 at 16:42

Not sure if this if your problem, but most of that firebase code isn't all necessary...

Notice you call getNom_livre (and others) and then call setNom_livre (and others) with the exact same value?
You also make a new Book when you already have one.

Book valueBook = dataSnap.getValue(Book.class); // This is a Book
keyId = dataSnap.getKey();

String userBd = valueBook.getId_user();
if (userBd.equalsIgnoreCase(id_user)) {
    String titreLivreToDisplay = valueBook.getNom_livre();
    ...

    item = new Book(); // Why do you need a new one?
    item.setNom_livre(titreLivreToDisplay);
    ... 

    feedItems.add(item);
}

First, you should move this before the firebase method. There is no need to recreate the adapter every data update.

listAdapter = new MyBookListAdapter(ListOfMyBookActivity.this, feedItems);
listView.setAdapter(listAdapter);
listView.setOnItemClickListener(myClickListener);

ref.orderByChild("date_creation")...

but i have duplicate item , the old one and the new one

You simply need to clear the adapter to remove old data and add the new stuff

ref.orderByChild("date_creation")
    .limitToLast(10)
    .addValueEventListener(new ValueEventListener() {
         @Override
         public void onDataChange(DataSnapshot dataSnapshot) {
             // Remove old data
             feedItems.clear(); 

             // Add new data
             for (DataSnapshot dataSnap : dataSnapshot.getChildren()) {

                 Book valueBook = dataSnap.getValue(Book.class);
                 keyId = dataSnap.getKey();

                  String userBd = valueBook.getId_user();
                  if (userBd.equalsIgnoreCase(id_user)) {
                      valueBook.setKeyIdNode(keyId);
                      feedItems.add(valueBook);
                  }
             }
             Collections.reverse(feedItems);
             listAdapter.notifyDataSetChanged(); // Tell adapter of new data

I 'm using firebase for the first time, thanks for your observations, I'll think about it. — Amal, Apr 18 '17 at 12:57

score 1 · Answer 2 · answered Apr 17 '17 at 14:30

Use feedItems.clear() before getting updated data from firebase.

Try this:

ref.orderByChild("date_creation").limitToLast(10).addValueEventListener(new ValueEventListener() {

    @Override
    public void onDataChange(DataSnapshot dataSnapshot) {

        feedItems.clear();

        .............
        ..................
    }
});

Mukesh M · Accepted Answer · 2017-04-17T14:14:06.757

0

try

    feedItems.remove(position);
   // listView.invalidateViews();
     arrayAdapter.notifyDataSetChanged();

edited Apr 17 '17 at 14:14

answered Apr 17 '17 at 13:53

Mukesh M

2,242
6
28
41

@Amal try this feedItems.remove(position); listView.invalidateViews(); – Mukesh M Apr 17 '17 at 14:14
It works but refer to this answer it is not a good idea [link](http://stackoverflow.com/a/16708283/3023772) – Amal Apr 17 '17 at 14:43
read comment of this answer http://stackoverflow.com/a/8309715/5227589 and i am not sure about performance or why it does not work with out i invalidateViews() – Mukesh M Apr 17 '17 at 14:49
I will accept your answer because it works for me. thanks – Amal Apr 17 '17 at 14:52

score 0 · Answer 4 · answered Apr 18 '17 at 07:28

use this in your adapter

public void dataSetChanged(ArrayList<Movie>list)
    {
        this.list=list;
        this.notifyDataSetChanged();
    }

and use it like this upadte your list data and after that use below line

customListViewAdapter.dataSetChanged(movieList);

score -1 · Answer 5 · answered Apr 17 '17 at 13:52

-1

use this for update your list notifyDataSetChanged()

answered Apr 17 '17 at 13:52

AMIT RANJAN

11
2

`listAdapter.notifyDataSetChanged();` is already in the question – OneCricketeer Apr 17 '17 at 16:43

Update listView after updating dataBase?

5 Answers5