What should I use in place of getWidth() and getHeight() to know when width is greater and when height is greater

Question

import android.app.Fragment;
import android.app.FragmentManager;
import android.app.FragmentTransaction;
import android.support.v7.app.AppCompatActivity;
import android.os.Bundle;
import android.view.Display;
import android.view.WindowManager;

public class MainActivity extends AppCompatActivity {

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);


        FragmentManager fm=getFragmentManager();
        FragmentTransaction ft= fm.beginTransaction();


        WindowManager wm= getWindowManager();
        Display d=wm.getDefaultDisplay();

        if (d.getWidth()>d.getHeight())
        {
            Fragment1 f1 = new Fragment1();
            ft.replace(android.R.id.content, f1);
        }
        else
        {
            Fragment2 f2 = new Fragment2();
            ft.replace(android.R.id.content, f2);
        }
    ft.commit();
    }
}

I am trying to use fragments in android and want to display fragment1 when width of display is greater than height of display and fragment2 when height of display is greater than width of display but when using getWidth() and getHeight() android studio is saying that these methods are depricated. Then how to know when width is greater and when height is greater?

are you trying to show fragment one on portrait and fragment 2 on landscape — A.s.ALI, Apr 19 '17 at 06:31
When you get four answers in as many minutes, it's a sure sign that you did not do enough research. — Mike M., Apr 19 '17 at 06:34

Ferdous Ahamed · Accepted Answer · 2017-04-19T06:39:50.673

4

Use DisplayMetrics instead of Display.

Try this:

import android.app.Fragment;
import android.app.FragmentManager;
import android.app.FragmentTransaction;
import android.support.v7.app.AppCompatActivity;
import android.os.Bundle;
import android.view.Display;
import android.view.WindowManager;
import android.util.DisplayMetrics;

public class MainActivity extends AppCompatActivity {

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);


        FragmentManager fm=getFragmentManager();
        FragmentTransaction ft= fm.beginTransaction();

        DisplayMetrics displayMetrics = new DisplayMetrics();
        getWindowManager().getDefaultDisplay().getMetrics(displayMetrics);
        int height = displayMetrics.heightPixels;
        int width = displayMetrics.widthPixels;

        if (width > height)
        {
            Fragment1 f1 = new Fragment1();
            ft.replace(android.R.id.content, f1);
        }
        else
        {
            Fragment2 f2 = new Fragment2();
            ft.replace(android.R.id.content, f2);
        }

        ft.commit();
    }
}

edited Apr 19 '17 at 06:39

answered Apr 19 '17 at 06:33

Ferdous Ahamed

21,438
5
52
61

@Ankit kindly read this: http://stackoverflow.com/help/someone-answers – Ferdous Ahamed Apr 19 '17 at 06:43
sir, I was about to check the tick but the site was giving warning that I can check the tick only after 10 minutes so I was waing for that – Ankit Apr 19 '17 at 06:50
You have already accepted this answer. Thank you :) Make sure to give an up-vote later. – Ferdous Ahamed Apr 19 '17 at 06:52
already done friend – Ankit Apr 19 '17 at 07:02
Previously you accepted my answer but now you have changed it. May I know why? – Ferdous Ahamed Apr 19 '17 at 07:11

score 3 · Answer 2 · answered Apr 19 '17 at 06:33

You can use DisplayMetrics

DisplayMetrics displaymetrics = new DisplayMetrics();
getWindowManager().getDefaultDisplay().getMetrics(displaymetrics);
int height = displaymetrics.heightPixels;
int Width = displaymetrics.widthPixels;

if (Width  > height )
    {
        Fragment1 f1 = new Fragment1();
        ft.replace(android.R.id.content, f1);
    }
    else
    {
        Fragment2 f2 = new Fragment2();
        ft.replace(android.R.id.content, f2);
    }

thanks for the answer and the valuable time – Ankit Apr 19 '17 at 06:34 — Ankit, Apr 19 '17 at 06:34

score 2 · Answer 3 · answered Apr 19 '17 at 06:33

2

DisplayMetrics displaymetrics = new DisplayMetrics();
mContext.getWindowManager().getDefaultDisplay().getMetrics(displaymetrics);
int screenWidth = displaymetrics.widthPixels;
int screenHeight = displaymetrics.heightPixels;

answered Apr 19 '17 at 06:33

DroidDev

789
9
19

Fathima km · Answer 4 · 2017-04-19T06:37:44.620

1

Use this to get width and height.

int Measuredwidth = 0;  
int Measuredheight = 0;  
Point size = new Point();
WindowManager wm = getWindowManager();

if(Build.VERSION.SDK_INT >= Build.VERSION_CODES.HONEYCOMB)    {
    wm.getDefaultDisplay().getSize(size);
    Measuredwidth = size.x;
    Measuredheight = size.y; 
}else{
    Display d = w.getDefaultDisplay(); 
    Measuredwidth = d.getWidth(); 
    Measuredheight = d.getHeight(); 
}

edited Apr 19 '17 at 06:37

answered Apr 19 '17 at 06:32

Fathima km

2,539
3
18
26

where is this x and y coming from – Ankit Apr 19 '17 at 06:33
it is the display x and y dimensions in pixels – Fathima km Apr 19 '17 at 06:39

score 1 · Answer 5 · answered Apr 19 '17 at 06:35

Try

 context.getWindowManager().getDefaultDisplay().getMetrics(dm);
 if(dm.widthPixels > dm.heightPixels) {
     //width is greater, i.e. landscape
     Fragment1 f1 = new Fragment1();
        ft.replace(android.R.id.content, f1);
 } else {
     //height is greater i.e. portrait
     Fragment2 f2 = new Fragment2();
     ft.replace(android.R.id.content, f2);
 }

You can detect orientation directly by overriding onConfigurationChanges in MainActivity

@Override
public void onConfigurationChanged(Configuration newConfig) {
    super.onConfigurationChanged(newConfig);

    // Checks the orientation of the screen
    if (newConfig.orientation == Configuration.ORIENTATION_LANDSCAPE) {
        Fragment1 f1 = new Fragment1();
        ft.replace(android.R.id.content, f1);
    } else if (newConfig.orientation == Configuration.ORIENTATION_PORTRAIT){
        Fragment2 f2 = new Fragment2();
        ft.replace(android.R.id.content, f2);
    }
}

//Add configChanges in manifest
<activity android:name=".MainActivity"
      android:configChanges="orientation|keyboardHidden"
      android:label="@string/app_name">

What should I use in place of getWidth() and getHeight() to know when width is greater and when height is greater

5 Answers5