PHP header() not working?

Question

I'm struggling with this issue, for some reason header("Location:http://corocloud.com/index.php/"); is not working, i've tried other paths to the file but none work, header("Location:index.php");, header("index.php");, header("./index.php/");

none of these work, my code is this:

<!DOCTYPE html>
<html>
    <head>
      <title>CoroCloud</title>
      <meta name="viewport" content="width=device-width, initial-scale=1">
      <script src="./js/material.min.js"></script>
      <link rel="stylesheet" href="https://fonts.googleapis.com/icon?family=Material+Icons">
      <link rel="stylesheet" href="https://code.getmdl.io/1.3.0/material.pink-indigo.min.css" />
      <style>.mdl-layout{align-items:center;justify-content:center;}.mdl-layout__content{padding:24px;flex:none;}</style>
  </head>
  <body>
    <div class="mdl-layout mdl-js-layout mdl-color--grey-100">
      <main class="mdl-layout__content">
        <div class="mdl-card mdl-shadow--6dp">
          <div class="mdl-card__title mdl-color--primary mdl-color-text--white">
            <h2 class="mdl-card__title-text">CoroCloud</h2>
          </div>
          <div class="mdl-card__supporting-text">
            <form method="POST">
              <div class="mdl-textfield mdl-js-textfield">
                <input class="mdl-textfield__input" type="text" name="uname" />
                <label class="mdl-textfield__label" for="uname">Username</label>
              </div>
              <div class="mdl-textfield mdl-js-textfield">
                <input class="mdl-textfield__input" type="password" name="pass"/>
                <label class="mdl-textfield__label" for="pass">Password</label>
              </div>
              <div class="mdl-card__actions">
                <input type="submit" class="mdl-button mdl-button--colored mdl-js-button mdl-js-ripple-effect" name="sub">
              </div>
            </form>
          </div>
        </div>
      </main>
    </div>
    <?php 
      session_start();
       // this will trigger when submit button click
       if(isset($_POST['sub'])){
       
        $db = new mysqli("localhost","user","password","db");
       
        // create query
        $query = "SELECT * FROM users WHERE user='".$_POST['uname']."' AND password='".sha1($_POST['pass'])."'";
       
        // execute query
        $sql = $db->query($query);
        // num_rows will count the affected rows base on your sql query. so $n will return a number base on your query
        $n = $sql->num_rows;
       
        // if $n is > 0 it mean their is an existing record that match base on your query above 
        if($n > 0){
                              $_SESSION['username'] = $_POST['uname'];
                              $_SESSION['password'] = $_POST['pass'];
                              $_SESSION['userobj'] = mysql_fetch_assoc($query);
     header("Location: index.php");
   exit();
        } else {
       
         echo "Incorrect username or password";
        }
       }
      ?>
  </body>
</html>

I know the code is being executed, as the every $_SESSION var is getting value, why does header not work?

The file i'm trying to redirect is in the same folder by the way.

EDIT: Don't run the snippet, as it has PHP

Try `header("Location: index.php");` Note the space between **the path** and the **:** — Dash, Apr 21 '17 at 08:54
if you are outputting something before the header it will not work — Icewine, Apr 21 '17 at 08:54
Post the full code. Something might be output before `header` is called — Rotimi, Apr 21 '17 at 08:55
@DanFromGermany it's not a copy, as the solutions provided there are not working, anyway just in case. How do I close it? — Alex Coronas, Apr 21 '17 at 09:17

score 4 · Answer 1 · answered Apr 21 '17 at 09:36

Add this code at the top of your code // before html code

ob_start();
session_start();
    // this will trigger when submit button click
    if(isset($_POST['sub'])){

        $db = new mysqli("localhost","user","password","db");

        // create query
        $query = "SELECT * FROM users WHERE user='".$_POST['uname']."' AND password='".sha1($_POST['pass'])."'";

        // execute query
        $sql = $db->query($query);
        // num_rows will count the affected rows base on your sql query. so $n will return a number base on your query
        $n = $sql->num_rows;

        // if $n is > 0 it mean their is an existing record that match base on your query above 
        if($n > 0){
                      $_SESSION['username'] = $_POST['uname'];
                      $_SESSION['password'] = $_POST['pass'];
                      $_SESSION['userobj'] = mysql_fetch_assoc($query);
        header("Location: index.php");
        exit();
        } else {

            echo "Incorrect username or password";
        }
    }

// Put here html code //

score 2 · Answer 2 · answered Apr 21 '17 at 09:17

2

You cannot output stuff and after that perform a "header" operation in php. So, modify your code to first do all the php stuff and after that output html. You MUST not have ANY output (html, warnings, etc.) before that "header" line. see: http://php.net/manual/en/function.header.php

answered Apr 21 '17 at 09:17

Paladin

1,637
13
28

Totally beat you by 23 seconds. – Vbudo Apr 21 '17 at 09:18

score 1 · Answer 3 · answered Apr 21 '17 at 09:08

1

Please try with ob_start() function before and Header Location

ob_start();
header("Location:http://corocloud.com/index.php/");
exit;

I hope it will help ! you please provide the error what you are getting over there.

answered Apr 21 '17 at 09:08

Devdutt Sharma

391
1
2
10

thanks for the response, but adding ob_start(); and exit; didn't work. Wich error are you refering to? i don't think i'm getting an error – Alex Coronas Apr 21 '17 at 09:12
Have you got error reporting enabled? – RobFos Apr 21 '17 at 09:15
what output you getting after executing your code ? – Devdutt Sharma Apr 21 '17 at 09:18
Please use ob_start(); before starting your session – Devdutt Sharma Apr 21 '17 at 09:33

score 1 · Answer 4 · answered Apr 21 '17 at 09:16

1

You may not produce output (HTML or echo) before a header is called. http://php.net/manual/en/function.header.php

answered Apr 21 '17 at 09:16

Vbudo

405
4
9

score 1 · Accepted Answer · answered Apr 21 '17 at 09:20

As Icewine pointed out correctly, headers should be set before any output is created.

So either move your code that is setting the header to the beginning of your script, or capture all output with output buffering, by calling ob_start() at the beginning of your script.

Also It is customary to not send any content when redirecting with a Location header, another reason to move your logic for the redirect to the beginning of your script, and then call exit() after setting the header.

Thank you! I didn't know that i couldn't output before changing the header. As a mattern of fact i have this same code in a hosting, and it works. That's strange — Alex Coronas, Apr 21 '17 at 09:32

score 0 · Answer 6 · answered Apr 21 '17 at 13:18

0

Better way is always try to follow some php basics.

<?php
ob_start();
session_start();

exit after header

header("Location:demo.php");
exit;

answered Apr 21 '17 at 13:18

Ahmed Ginani

6,522
2
15
33

PHP header() not working?

6 Answers6