How to access variable value from another php script

Question

I have read so many pages and am stuck on this for the past three hours now because it just won't work.

I keep getting Notice: Undefined index: firstname

here is the bulk of the segment that isn't working:

$errMsg = "";

function sanitise($data){
    $data = trim($data);
    $data = stripslashes($data);
    $data = htmlspecialchars($data);
    return $data;
}

if (isset($_POST["firstname"]))
{
    $firstname = $_POST["firstname"];
    $firstname = sanitise($firstname);

    if (!preg_match("/^[A-Za-z \-]+$/",$firstname))
    {
        $errMsg .= "First name must contain only letters or hyphens.<br/>";
    }

    if (strlen($firstname) > 40)
    {
        $errMsg .= "First name cannot be over 40 characters long.<br/>";
    }
} else {
    $errMsg .= "First name cannot be empty.<br/>";
    $firstname = "";
}


    if ($errMsg != "")
    {
    header("Location: fix_order.php?firstname=$firstname");
    }

this is the code on fix_order.php where I want to access the variables.

$firstname = $_GET["firstname"];
echo "<p>firstname is $firstname .</p>";

I have tested the $firstname on the first page and it echo's the values just fine.

You can also use sessions to store the variables across pages. See [this answer](https://stackoverflow.com/a/11803399/5914775) for more information. — Tom Udding, May 19 '17 at 13:52
Use `header("Location: fix_order.php?firstname=".$firstname);` — Atul Sharma, May 19 '17 at 13:55
Where is `$firstname` defined in the script that writes the header? — Matt S, May 19 '17 at 13:55
I suspect there's something you're not showing us - technically what you've got there *should* work. — CD001, May 19 '17 at 13:55
sorry the assignment requirements asks to use Query string and not session storage. — Noob, May 19 '17 at 13:58
How would I find these errors? do you seriously want me to put 350 lines of code on this? what should I look for ? — Noob, May 19 '17 at 14:00
Notice: Undefined index: firstname in /home/students/accounts/s6883826/cos10011/www/htdocs/assign3/fix_order.php on line 24 — Noob, May 19 '17 at 14:02
Write `print_r($_SERVER["QUERY_STRING"]);` I was hoping that by saying print you will use `print_r` — Ravi Hirani, May 19 '17 at 14:08
@RaviHirani sorry mate I am still learning... I did what you typed, and still the output is "array" — Noob, May 19 '17 at 14:11
@Noob: Please refer this link:- https://stackoverflow.com/questions/1647322/whats-the-difference-between-echo-print-and-print-r-in-php — Ravi Hirani, May 23 '17 at 06:11

score 1 · Accepted Answer · answered May 19 '17 at 14:11

1

change your code to

$firstname = $_GET["errMsg"];
echo "<p>firstname is $firstname .</p>";

You can't access $firstname as this is the value not the key. errMsg is the key you should use.

answered May 19 '17 at 14:11

Junius L

15,881
6
52
96

Notice: Undefined index: errMsg in /home/students/accounts/s6883826/cos10011/www/htdocs/assign3/fix_order.php on line 24 – Noob May 19 '17 at 14:14
sorry mate, i had it as errMsg before to test something. I changed the key back to firstname and I still run into the same errors. Notice: Undefined index: firstname in /home/students/accounts/s6883826/cos10011/www/htdocs/assign3/fix_order.php on line 24 – Noob May 19 '17 at 14:17
the code you pasted is not complete right?, do you have any other `header` location? – Junius L May 19 '17 at 14:18
i pasted it there... but can you see it? – Noob May 19 '17 at 14:24
i added it. it isn't complete yet. matter of fact most of it will be scrapped as I am recreating a new page there. below the 3rd php script, will be changed... – Noob May 19 '17 at 14:28
I think you are calling `$_GET['firstaname']` in either `main.inc` or `menu.inc` as I have commented them out and it works, no errors. – Junius L May 19 '17 at 14:32
I just posted the answer from one of the comments from the actual question. Thank you anyway for your time! I really appreciate it! especially after 4 hours of pulling my hair out... was a simple full stop... – Noob May 19 '17 at 14:34

score 0 · Answer 2 · edited May 19 '17 at 14:01

0

Looks fine to me, it should work.

To get rid of the notice, you need to define variable by using isset()

$firstname = isset($_GET['firstname']) ? $_GET['firstname'] : '';

OR

if(isset($_GET['firstname'])) {
    $firstname = $_GET['firstname'];
} else {
    $firstname = '';
}

edited May 19 '17 at 14:01

Ravi Hirani

6,511
1
27
42

answered May 19 '17 at 13:53

devofash

328
2
13

How to access variable value from another php script

2 Answers2