Getting Error when Wrong $_GET Parameter in URL is Used

Question

and can't get this to work. I want to get variable from URL, like:

domain.com?region=STATE

if (empty($_GET)) {
    echo 'American';

}

else {
    $t = $_GET["region"];
    if ($t == "Texas") {
        echo "Texan";
    } elseif ($t == "California") {
        echo "Californian";
    } else {
        echo "American";
    }
}

This does work. However in case there's wrong parameter input, like:

domain.com?asdasd=whatever

I get an error:

"Notice: Undefined index: region in test.php on line 19"

Can you tell me how can I prevent this error from appearing and basically treat it as empty variable and return "American" instead?

I tried this code, but it doesn't work:

if (empty($_GET)) {
    echo 'American';

}
elseif ($_GET != "region") {
    echo 'Anything Else';
}
else {
    $t = $_GET["region"];
    if ($t == "Texas") {
        echo "Texan";
    } elseif ($t == "California") {
        echo "Californian";
    } else {
        echo "American";
    }
}

Even if URL is true:

domain.com?region=Texas

is still get "Anything Else" in the output.

Possible duplicate of [PHP: "Notice: Undefined variable", "Notice: Undefined index", and "Notice: Undefined offset"](http://stackoverflow.com/questions/4261133/php-notice-undefined-variable-notice-undefined-index-and-notice-undef) — Qirel, May 20 '17 at 07:21

Amit Gaud · Answer 1 · 2017-05-20T07:19:16.053

1

USE $_GET['region'] not $_GET itself

 if (!isset($_GET["region"]) || empty($_GET["region"])) {
        echo 'American';

    }
    else {
        $t = $_GET["region"];
        if ($t == "Texas") {
            echo "Texan";
        } elseif ($t == "California") {
            echo "Californian";
        } else {
            echo "American";
        }
    }

edited May 20 '17 at 07:19

answered May 20 '17 at 07:14

Amit Gaud

756
6
15

thanx Amit, but it still doesn't work. I get the same output "Anything Else" if I use one of the defined states. IE: test.php?region=Texas – reizer May 20 '17 at 07:16
@reizer try this I have changed litile logic in code – Amit Gaud May 20 '17 at 07:20

score 1 · Accepted Answer · answered May 20 '17 at 07:18

1

Use isset(($_GET['region']) as it does not emit a notice if fed an undefined variable:

if (!isset($_GET['region'])) {
    echo 'American';
} else {
    $t = $_GET["region"];
    if ($t == "Texas") {
        echo "Texan";
    } elseif ($t == "California") {
        echo "Californian";
    } else {
        echo "American";
    }
}

answered May 20 '17 at 07:18

Enstage

2,106
13
20

If mine is the correct answer then check the green tick below the voting buttons to mark it as such :) – Enstage May 20 '17 at 07:21

score 1 · Answer 3 · answered May 20 '17 at 07:19

You could use array_key_exists('region',$_GET) to test if the parameter exists like this perhaps

if( !empty( $_GET ) ){

    $t = array_key_exists( 'region', $_GET ) && !empty( $_GET['region'] ) ? strtolower( $_GET['region'] ) : false;

    if( $t ){
        switch( $t ){
            case 'texas': echo 'Texan';break;
            case 'california': echo "Californian"; break;
            default: echo 'Other State'; break;
        }
    } else {
        echo 'Anything Else';
    }
} else {
    echo 'American';
}

wow thanx, you even included lowercase/Uppercase correction just in case. — reizer, May 20 '17 at 07:28

score 1 · Answer 4 · answered May 20 '17 at 07:22

Try this too:

<?php

        if (empty($_GET)) {
            echo 'American';
        } else if($_GET){
            echo 'No Error! (Anything Else)';
        }

        else {
            $t = $_GET["region"];
            if ($t == "Texas") {
                echo "Texan";
            } elseif ($t == "California") {
                echo "Californian";
            } else {
                echo "American";
            }
        }

    ?>

Getting Error when Wrong $_GET Parameter in URL is Used

4 Answers4