PHP sets new value with if statment in foreach (Laravel)

Question

I'm using laravel if that could be the issue (I'm in the controller) So I have this code.

If my $pool->status is etc OFFLINE it sets it to ONLINE. why is this happening?

foreach($pools as $pool){
        if ($pool->status = 'ONLINE') {
            $pool->cstatus = '
            <i class="zmdi zmdi-shield-check zmdi-hc-lg text-success" data-toggle="tooltip" data-placement="right" title="" data-original-title="OK"></i>
            ';
        }
        else {
            $pool->cstatus = '
            <i class="zmdi zmdi-help zmdi-hc-lg text-muted" data-placement="right" title="" data-original-title="Status unknown."></i>
            ';
        }
    }

score 1 · Answer 1 · answered May 27 '17 at 01:08

1

There is difference in "=" and "==" operators. = is assingment operator while == is comparison operator.

Change

  if ($pool->status = 'ONLINE') {

To

 if ($pool->status == 'ONLINE') {

answered May 27 '17 at 01:08

VK321

5,768
3
44
47

score 1 · Answer 2 · answered May 27 '17 at 01:10

1

You used assignemnt operator =, not a comparsion operator.

So:

if ($pool->status == 'ONLINE') {}

Not:

if ($pool->status = 'ONLINE') {}

You can go with yoda condition:

if ('ONLINE' == $pool->status) {}

Because that would throw an error when you mistake operators.

These mistakes are hard to debug, especially for not experienced programmers.

answered May 27 '17 at 01:10

Mateusz Sip

1,280
1
11
11

Thanks, also great with the link! – joveice May 27 '17 at 01:12

score 0 · Answer 3 · answered May 27 '17 at 01:09

You are using assignment operator in your if statement, instead of conditional equals operator. It is the different between using = and ==

foreach($pools as $pool){
        if ($pool->status == 'ONLINE') {
            $pool->cstatus = '
            <i class="zmdi zmdi-shield-check zmdi-hc-lg text-success" data-toggle="tooltip" data-placement="right" title="" data-original-title="OK"></i>
            ';
        }
        else {
            $pool->cstatus = '
            <i class="zmdi zmdi-help zmdi-hc-lg text-muted" data-placement="right" title="" data-original-title="Status unknown."></i>
            ';
        }
    }

PHP sets new value with if statment in foreach (Laravel)

3 Answers3