Undefined index: sort

Question

I'm trying to sort but that says sort is undefined:

Notice: Undefined index: sort in C:\xampp\htdocs\index.php on line 23

Notice: Undefined index: sort in C:\xampp\htdocs\index.php on line 27

Notice: Undefined index: sort in C:\xampp\htdocs\index.php on line 31

Notice: Undefined index: sort in C:\xampp\htdocs\index.php on line 35

Anyone can help?

            <tbody>
                    <?php
                            $sortby = isset($_GET['sort']) ? $_GET['sort'] : 'id';
                            if ($_GET['sort'] == 'id')
                            {
                                $sql .= " ORDER BY id";
                            }
                            elseif ($_GET['sort'] == 'nome')
                            {
                                $sql .= " ORDER BY nome";
                            }
                            elseif ($_GET['sort'] == 'idade')
                            {
                                $sql .= " ORDER BY idade";
                            }
                            elseif($_GET['sort'] == 'peso')
                            {
                                $sql .= " ORDER BY peso";
                            }   
                                $serverName = "asdaf-DEMO"; 
                                $options = array(  "UID" => "sa",  "PWD" => "fasdasd",  "Database" => "demo");
                                $conn = sqlsrv_connect($serverName, $options);
                                    if( $conn ) {
                                    $sql="SELECT * FROM cliente";
                                    $aResult=sqlsrv_query($conn, $sql);
                                    while($rows = sqlsrv_fetch_array($aResult))
                                    { 
                                    $id = $rows['id'];
                                    $nome = $rows['nome'];
                                    $idade = $rows['idade'];
                                    $peso = $rows['peso'];


                    ?>

Possible duplicate of [PHP: "Notice: Undefined variable", "Notice: Undefined index", and "Notice: Undefined offset"](https://stackoverflow.com/questions/4261133/php-notice-undefined-variable-notice-undefined-index-and-notice-undef) — schellingerht, Jun 16 '17 at 09:13

Mohammad Hamedani · Accepted Answer · 2017-06-16T09:28:24.230

You fill $sortby variable, so use it instead of $_GET['sort'] in if conditions. Additionally overwrite $sql after if/else conditions:

<tbody>
    <?php
            $sortby = isset($_GET['sort']) ? $_GET['sort'] : 'id';
            $sortOrder = isset($_GET['order']) ? $_GET['order'] : 'ASC';
            $orderBy = '';
            if ($sortby== 'id')
            {
                $orderBy .= " ORDER BY id";
            }
            elseif ($sortby== 'nome')
            {
                $orderBy .= " ORDER BY nome";
            }
            elseif ($sortby== 'idade')
            {
                $orderBy .= " ORDER BY idade";
            }
            elseif($sortby== 'peso')
            {
                $orderBy .= " ORDER BY peso";
            }   
                $serverName = "asdaf-DEMO"; 
                $options = array(  "UID" => "sa",  "PWD" => "fasdasd",  "Database" => "demo");
                $conn = sqlsrv_connect($serverName, $options);
                    if( $conn ) {
                    $sql="SELECT * FROM cliente" . $orderBy . ' ' . $sortOrder;
                    $aResult=sqlsrv_query($conn, $sql);
                    while($rows = sqlsrv_fetch_array($aResult))
                    { 
                    $id = $rows['id'];
                    $nome = $rows['nome'];
                    $idade = $rows['idade'];
                    $peso = $rows['peso'];


    ?>

Thanks, btw it only sort ASC, how can I make if I click again to sort DESC? — Goncalo Simoes, Jun 16 '17 at 09:25
You can send query parameter like `$_GET['order']` and use it. I updated my answer to work php codes, but i haven't access to your html codes to update it. — Mohammad Hamedani, Jun 16 '17 at 09:30

score 0 · Answer 2 · answered Jun 16 '17 at 09:03

0

replace all if ($_GET['sort'] with if($sortBy

The reason you're getting this error is because you have only one isset check. That's good but later in code you go back to using $_GET['sort'] without checking if it's set.

answered Jun 16 '17 at 09:03

Tim van Uum

1,873
1
17
36

Notice: Undefined variable: sortBy in C:\xampp\htdocs\index.php on line 23 – Goncalo Simoes Jun 16 '17 at 09:06
Sorry had to be `$sortby` (lowercase), but you could have seen that yourself. – Tim van Uum Jun 16 '17 at 09:07

Undefined index: sort

2 Answers2