Run Thread 2 threads with wait and notify

Question

I am new to Java Multi-threading programming. Here I want to run two threads by run thread 1 wait() notift() then thread 2 wait() notify() like wise.

can someone help me to achieve the expected output which is given below

Code

class RunnableDemo implements Runnable {
   private Thread t;
   private String threadName;

   RunnableDemo( String name) {
      threadName = name;
      System.out.println("Creating " +  threadName );
   }

   public void run() {
      System.out.println("Running " +  threadName );
    synchronized (t){
      try {
         for(int i = 1; i < = 5; i--) {
            System.out.println("Thread: " + threadName + ", " + i);
            wait();
            notify();
         }
      }catch (InterruptedException e) {
         System.out.println("Thread " +  threadName + " interrupted.");
      }
    }
      System.out.println("Thread " +  threadName + " exiting.");
   }

   public void start () {
      System.out.println("Starting " +  threadName );
      if (t == null) {
         t = new Thread (this, threadName);
         t.start ();
      }
   }
}

public class TestThread {

   public static void main(String args[]) {
      RunnableDemo R1 = new RunnableDemo( "Thread-1");
      R1.start();

      RunnableDemo R2 = new RunnableDemo( "Thread-2");
      R2.start();
   }   
}

Expected output is

Creating Thread-1
Starting Thread-1
Creating Thread-2
Starting Thread-2
Running Thread-1
Thread: Thread-1, 1
Running Thread-2
Thread: Thread-2, 1
............
Running Thread-1
Thread: Thread-1, 5
Running Thread-2
Thread: Thread-2, 5

Current output with exception is

Creating Thread-1
Starting Thread-1
Creating Thread-2
Starting Thread-2
Running Thread-1
Thread: Thread-1, 1
Running Thread-2
Thread: Thread-2, 1
Exception in thread "Thread-1" Exception in thread "Thread-2" java.lang.IllegalMonitorStateException
    at java.lang.Object.wait(Native Method)
    at java.lang.Object.wait(Object.java:502)
    at RunnableDemo.run(TestThread.java:16)
    at java.lang.Thread.run(Thread.java:745)
java.lang.IllegalMonitorStateException
    at java.lang.Object.wait(Native Method)
    at java.lang.Object.wait(Object.java:502)
    at RunnableDemo.run(TestThread.java:16)
    at java.lang.Thread.run(Thread.java:745)

Read up on Java threads [here](http://docs.oracle.com/javase/tutorial/essential/concurrency/index.html) — Kevin Anderson, Jun 26 '17 at 08:31
@KevinAnderson so is there anyway to achieve my expected result — Sathish Sivanandam, Jun 26 '17 at 08:34
Probably, yes. Once you have learned how to use threads it should be possible. — Kevin Anderson, Jun 26 '17 at 08:39

score 0 · Answer 1 · answered Jun 26 '17 at 08:34

You are getting wait/notify wrong.

In order to notify another thread, you have to call notify on another object.

What your code does is: a thread puts itself into wait ... to later notify itself.

In that sense: step back and read how to properly use these two methods; start reading here for example.

score 0 · Accepted Answer · answered Jun 26 '17 at 09:35

You should use wait() and notify() on same object to communicate.

class RunnableDemo implements Runnable {
    private ThreadMonitor lock;
    private String threadName;
    private String otheThreadName;

    RunnableDemo(String name, ThreadMonitor lock, String otheThreadName) {
        this.threadName = name;
        this.lock = lock;
        this.otheThreadName = otheThreadName;
        System.out.println("Creating " + threadName);
    }

    public void run() {

        synchronized (lock) {
            try {

                for (int i = 1; i <= 5; i++) {
                    while (!lock.getRunningThread().equals(threadName)) {
                        lock.wait();
                    }
                    System.out.println("Running " + threadName);
                    System.out.println("Thread: " + threadName + ", " + i);
                    lock.setRunningThread(otheThreadName);
                    lock.notify();
                }
            } catch (InterruptedException e) {
                System.out.println("Thread " + threadName + " interrupted.");
            }
        }
        System.out.println("Thread " + threadName + " exiting.");
    }

    public void start() {
        System.out.println("Starting " + threadName);

        Thread t = new Thread(this, threadName);
        t.start();
    }

}

public class TestThread {

    public static void main(String args[]) {
        ThreadMonitor lock = new ThreadMonitor("Thread-1");
        RunnableDemo R1 = new RunnableDemo("Thread-1", lock, "Thread-2");
        R1.start();

        RunnableDemo R2 = new RunnableDemo("Thread-2", lock, "Thread-1");
        R2.start();
    }
}

class ThreadMonitor {
    private String runningThread;

    public ThreadMonitor(String runningThread) {
        this.runningThread = runningThread;
    }

    public String getRunningThread() {
        return runningThread;
    }

    public void setRunningThread(String threadName) {
        runningThread = threadName;
    }
}

Run Thread 2 threads with wait and notify

2 Answers2