While compiling the program, I am getting ArrayIndexOutOfBound exception

Question

I am getting ArrayIndexOutOfBound exception in line 14.

package str.files;

public class Duplicate {

public static void main(String[] args)
{
    int count=0;
    String s="this is a java  is program ";
    String[] dup= s.split(" ");

    for(int i=1;i<=dup.length;i++)
    {
        //System.out.println(dup[i]);
        if(dup[i].equalsIgnoreCase(dup[i+1]))
        {

            count++;
        }           
        System.out.println("The duplicate character is : :"+dup[i]);    
    }

    System.out.println("no. of occurances of the program is : "+count);

}

}

The exception I'm getting is :

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 7
   at str.files.Duplicate.main(Duplicate.java:14)

Java arrays have indexes from 0 to length-1, not 1 to length. — Andy Turner, Jun 29 '17 at 05:42
Note: this exception does not occur when you are compiling: it happens when you run the code. — Andy Turner, Jun 29 '17 at 05:45
Also use `s.split("\\s+");` to split a single or multiple space. Also you are only checking that the duplicate is the next element — Scary Wombat, Jun 29 '17 at 05:48
@Scary Wombat could you plz suggest how can i check the duplicate? — manish, Jun 29 '17 at 08:07
see this question https://stackoverflow.com/questions/3951547/java-array-finding-duplicates — Scary Wombat, Jun 29 '17 at 08:10

score 0 · Answer 1 · edited Jun 29 '17 at 05:51

0

You only loop to dup.length - 1.

for(int i=1;i<dup.length - 1;i++)
{
    //System.out.println(dup[i]);
    if(dup[i].equalsIgnoreCase(dup[i+1]))
    {

        count++;
    }           
    System.out.println("The duplicate character is : :"+dup[i]);    
}

edited Jun 29 '17 at 05:51

Gilad Green

36,708
7
61
95

answered Jun 29 '17 at 05:42

Tien Nguyen Ngoc

1,555
1
8
17

what about element [0] ? – Scary Wombat Jun 29 '17 at 05:44
I don't know. His code don't start element [0] . – Tien Nguyen Ngoc Jun 29 '17 at 05:47

Ori Marko · Answer 2 · 2017-06-29T06:00:44.817

Because you use i+1 inside loop you can reach value i with less than dup.length - 1, otherwise you will go outside the bounds of the array.

Also start with i=0 which is the start of the array.

for(int i=0; i<dup.length - 1; i++) {
    //System.out.println(dup[i]);
    if(dup[i].equalsIgnoreCase(dup[i+1])) {
        count++;
    }           
    System.out.println("The duplicate character is : :"+dup[i]);    
}

While compiling the program, I am getting ArrayIndexOutOfBound exception

2 Answers2