Array.push() is not working?

Question

I have the following code where newUsers are not known outside of mongoose call. I have to return newUsers list.

Struggling for a long time. But not getting anything immproved.

exports.list = function(req, res) {

      User.find({ 'roles': 'user' }, '-salt -password -providerData').sort('-created').populate('user', 'displayName').lean().exec(function(err, users) {
        if (err) {
          return res.status(422).send({
            message: errorHandler.getErrorMessage(err)
          });
        }
        var i;
        var newUsers = [];
        users.forEach(function(user) {
          Customer.find({ user: user._id }).exec(function(err, customers) {
            if (err) {
              return res.status(400).send({
                message: errorHandler.getErrorMessage(err)
              });
            }
            user.customers = customers.length;
            newUsers.push(user);
            console.log(newUsers.length); // newUsers are known here
           return newUsers; **// does not workout**
          });
            console.log(newUsers.length); //newUsers are not known here
        });
      });
    };

@ponury-kostek - I am new to node and angular. I will try to understand — Sam, Jul 11 '17 at 07:16

score 1 · Answer 1 · answered Jul 11 '17 at 10:21

exports.list = function (req, res) {
    User.find({ 'roles': 'user' }, '-salt -password -providerData').sort('-created').populate('user', 'displayName').lean().exec(function (err, users) {
        if (err) {
            return res.status(422).send({
                message: errorHandler.getErrorMessage(err)
            });
        }
        var i;
        var newUsers = [];
        users.forEach(function (user) {
            Customer.find({ user: user._id }).exec(function (err, customers) {
                if (err) {
                    return res.status(400).send({
                        message: errorHandler.getErrorMessage(err)
                    });
                }
                user.customers = customers.length;
                newUsers.push(user);
                console.log(newUsers.length, newUsers);
            });
        });
    });
};

You need to read about asynchronious programming

score 0 · Accepted Answer · answered Jul 11 '17 at 07:15

You are returning inside the forEach(), As i think you should return outside the forEach() for better result.

Please try below code, Hope it will work for you :

exports.list = function (req, res) {
    User.find({ 'roles': 'user' }, '-salt -password -providerData').sort('-created').populate('user', 'displayName').lean().exec(function (err, users) {
        if (err) {
            return res.status(422).send({
                message: errorHandler.getErrorMessage(err)
            });
        }
        var i;
        var newUsers = [];
        users.forEach(function (user) {
            Customer.find({ user: user._id }).exec(function (err, customers) {
                if (err) {
                    return res.status(400).send({
                        message: errorHandler.getErrorMessage(err)
                    });
                }
                user.customers = customers.length;
                newUsers.push(user);
            });
        });
        console.log(newUsers.length);
        return newUsers;
    });
};

Are you want to push newUsers.push(user) or newUsers.push(customers) ? I think you want to do newUsers.push(customers). — Shubham Verma, Jul 11 '17 at 07:24
add "user.toJSON()" before "Customer.find({ user: user._id }).exec(function (err, customers) {" line. — Shubham Verma, Jul 11 '17 at 07:44

Array.push() is not working?

2 Answers2