LINQ- Max in where condition

Question

I have a class TaskWeekUI with this definition:

 public class TaskWeekUI    {
   public Guid TaskWeekId { get; set; }
   public Guid TaskId { get; set; }
   public Guid WeekId { get; set; }
   public DateTime EndDate { get; set; }
   public string PersianEndDate { get; set; }
   public double PlanProgress { get; set; }
   public double ActualProgress { get; set; }    }

and I wrote this query :

 TaskWeekUI ti =  tis.First( t => t.PlanProgress > 0 && t.EndDate ==  tis.Where(p => p.PlanProgress != null && p.PlanProgress > 0).Max(w => w.EndDate));

Is this query is true? Can I write my query better than this?

`p => p.PlanProgress != null` is not required in your `Where` clause — fearofawhackplanet, Dec 30 '10 at 11:16
See: http://stackoverflow.com/questions/1101841/linq-how-to-perform-max-on-a-property-of-all-objects-in-a-collection-and-retu — Danko Durbić, Dec 30 '10 at 11:30
possible duplicate of [How to use LINQ to select object with minimum or maximum property value](http://stackoverflow.com/questions/914109/how-to-use-linq-to-select-object-with-minimum-or-maximum-property-value) — nawfal, Jul 19 '14 at 18:47

score 39 · Accepted Answer · answered Dec 30 '10 at 11:31

39

I think you want the one whose PlanProgress > 0 has a most recent EndDate.

TaskWeekUI ti = tis.Where(t => t.PlanProgress > 0)
                   .OrderByDescending(t => t.EndDate)
                   .FirstOrDefault();

answered Dec 30 '10 at 11:31

Cheng Chen

42,509
16
113
174

1

+1, nice clear solution without any extraneous exceptions introduced by using Max. – WileCau Dec 31 '10 at 02:44
1

Tnx,I think it is a best any simple solution . – Shayan Jan 01 '11 at 07:50
2

Isn't it a waste of time to sort the whole list just to get the item with the highest `EndDate`? [This](http://stackoverflow.com/a/1101979/1219414) seems to be a better solution. – Juan Feb 25 '14 at 19:03
1

@JuanLuisSoldi: You are correct. The best solution should be O(n). But anyway it's acceptable, and it's the best solution base on build-in LINQ functions. – Cheng Chen Mar 02 '14 at 15:50

score 5 · Answer 2 · answered Dec 30 '10 at 11:22

This query seems to be correct from point of view of result obtained.

But in your inner query tis.Where(p => p.PlanProgress != null && p.PlanProgress > 0).Max(w => w.EndDate) is computed for each element in collection with t.PlanProgress > 0

So its a better way to obtain Max value outside of a query as follows:

var max = tis.Where(p => p.PlanProgress != null && p.PlanProgress > 0).Max(w => w.EndDate);
tis.First( t => t.PlanProgress > 0 && t.EndDate == max);

Going further p.PlanProgress != null is allways true since p.PlanProgress is not of Nullable type. So our code becomes like this:

var max = tis.Where(p => p.PlanProgress > 0).Max(w => w.EndDate);
    tis.First( t => t.PlanProgress > 0 && t.EndDate == max);

Or you can change a definition of your class and make p.PlanProgress of Nullable type:

public class TaskWeekUI    {
   public Guid TaskWeekId { get; set; }
   public Guid TaskId { get; set; }
   public Guid WeekId { get; set; }
   public DateTime EndDate { get; set; }
   public string PersianEndDate { get; set; }
   public double? PlanProgress { get; set; }
   public double ActualProgress { get; set; }    
} 

var max = tis.Where(p => p.PlanProgress.HasValue && p.PlanProgress.Value > 0).Max(w => w.EndDate);
    tis.First( t => t.PlanProgress.HasValue && t.PlanProgress.Value > 0 && t.EndDate == max);

+1, the only thing I would change is the `First` to a `FirstOrDefault` unless he can guarantee that there will always be an item with `PlanProgress > 0` — Matthew Abbott, Dec 30 '10 at 11:37
+1, but I think 'collection.Max' throws an exception if 'collection' is empty, so there probably needs to be an additional check before setting 'max'. The collection will be empty if all PlanProgress <= 0. Since there are checks for PlanProgress > 0 I assume PlanProgress <= 0 is legal and an exception probably wouldn't be expected. — WileCau, Dec 30 '10 at 12:20

score 0 · Answer 3 · answered Jul 07 '18 at 05:49

0

     var max_Query =
                   (from s in db.Songs
                    join bk in db.Albums on s.BookId equals addAlbumDetailsViewModel.BookId
                    select s.SongId).Max();
                            max_Query++;

answered Jul 07 '18 at 05:49

Varinder Singh Baidwan

203
2
13

score -1 · Answer 4 · answered Dec 30 '10 at 11:22

-1

You don't need compare PlanProgress with null because double is struct type, it can't be null.

If you want TaskWeekUI with Max EndDate and positive PlanProgress You can try this code:

TaskWeekUI ti = tis.Where(t => t.PlanProgress > 0).Max(w => w.EndDate);

answered Dec 30 '10 at 11:22

Eugene Gluhotorenko

3,094
2
33
52

It'll end up assigning `DateTime` to `TaskWeekUI` – nan Dec 30 '10 at 11:24
5

Cannot implicitly convert type 'System.DateTime' to 'TaskWeekUI' – Shayan Jan 01 '11 at 07:43

LINQ- Max in where condition

4 Answers4