Script doesn't counting properly

Question

I don't know what I'm doing wrong but I have problem with counting in javascript probably I missed something stupid and small but just cant find where.

So I want value of LGtv to increase on button click by 0.01 every time is clicked, at the same time I want value of CC to decrease on buttonClick by -1.

When I click first time all works, but when I clicked second time I'm getting message "You are a WINNER!" but LGtv value just increase by 0.01 so its not more than 0.05 like in my first If condition.

    <span id="currentclicks" class="btn btn-primary"></span>

    <div class="control-group">

    <label id="TvDiv" class="control-label"><span>0.00</span>
    </label>



    <div id="hm">
    <span id="TvButton" class="btn btn-large btn-primary pull-right"> Click </span>
    </div>

var LGtv = 0.00;
var CC = 10;

document.getElementById('currentclicks').innerHTML = CC;
document.getElementById('TvButton').onclick = function() {
  if (LGtv < 0.05) {
    document.getElementById('TvDiv').innerHTML = LGtv +=0.01;
  } else {
    document.getElementById('TvDiv').innerHTML = "You are a WINNER!";
    document.getElementById('hm').innerHTML = "";
  }
  localStorage.setItem('TvDiv', LGtv);

  if (LGtv++) {
    document.getElementById('currentclicks').innerHTML = CC -= 1;
  }
}

Thanks all for help!

Could you please add your HTML to the question - ideally in a working snippet so we can see how it all fits together. The issue is probably due to `LGtv++` - that's adding `1`, not `0.01`, and it's also pretty pointless in an `if` condition — Rory McCrossan, Aug 11 '17 at 16:01
`if (LGtv ++ ){` causing it to become 1.01 after first click — shakib, Aug 11 '17 at 16:05
Don't mix `+=`/`-=`/`++` into your expressions. They are bad practices. — Derek 朕會功夫, Aug 11 '17 at 16:08
Just put this in jsfiddle and @shakib is right. You need to evaluate what you are doing with `if (LGtv++) {` — Brandon Griffin, Aug 11 '17 at 16:20

score -1 · Answer 1 · answered Aug 11 '17 at 16:23

You should move if (LGtv++) { into the if where you are updating LGtv.

var LGtv = 0.00;
var CC = 10;

document.getElementById('currentclicks').innerHTML = CC;
document.getElementById('TvButton').onclick = function() {
  if (LGtv < 0.05) {
    document.getElementById('TvDiv').innerHTML = (LGtv += 0.01);
    document.getElementById('currentclicks').innerHTML = (CC -= 1);
  } else {
    document.getElementById('TvDiv').innerHTML = "You are a WINNER!";
    document.getElementById('hm').innerHTML = "";
  }
  localStorage.setItem('TvDiv', LGtv);    
}

Script doesn't counting properly

1 Answers1