how can i make a random link open in a new tab?

Question

I'm having an issue making a "random" link open up in a new tab.

      var randomLink = function(){

  var links = [
    'youtube.com/channel/UCkq10sWOK1ftebGZPFJBekA',
    'soundcloud.com/iamcardib',
    'soundcloud.com/rickybobby-slumpgod',
    'soundcloud.com/wavey-hefner',
    'soundcloud.com/liluzivert',
    'soundcloud.com/flameemojimusic',
    'soundcloud.com/youngthugworld',
    'soundcloud.com/kodak-black'

  ];


  var max = (links.length)

 window.open=links[Math.floor(Math.random()*max]

  var link = links[randomNumber];
  window.location = "http://" + link;

};

I've multiple times to get the links to open up in a new tab when I click a button but it will only open in the same tab.

`window.open=links[Math.floor(Math.random()*max]` I think you are missing a close bracket on this line — James Douglas, Aug 25 '17 at 18:17
@Amy — Not a duplicate of that. That is about a link opening in a new tab and the answers focus on using plain HTML rather then using JS as you need for a random URL like this question is asking about. — Quentin, Aug 25 '17 at 18:19
@Quentin - JavaScript answer is also present in the suggested duplicate - https://stackoverflow.com/a/33546457/477420. So far it is very unclear what you are having trouble with (short of some strange `window.open=links...` syntax) — Alexei Levenkov, Aug 26 '17 at 03:42

score 1 · Answer 1 · answered Aug 25 '17 at 18:17

1

window.open is a function. You need to call it, not assign a new value to it.

You also have a syntax error. A ) is missing.

window.open(links[Math.floor(Math.random()*max)]);

answered Aug 25 '17 at 18:17

Quentin

914,110
126
1,211
1,335

James Douglas · Answer 2 · 2017-08-25T18:37:47.947

0

The syntax of window.open is window.open(stuff) not window.open=stuff, because window.open is a function.

As @Quentin said,

window.open is a function. You need to call it, not assign a new value to it.

Functions are called like this: functionName(parameters);

Values are assigned like this: variableName=value;

Also, you are missing a close bracket and a semicolon. If you apply these,

window.open=links[Math.floor(Math.random()*max]

becomes

window.open(links[Math.floor(Math.random()*max)]);

edited Aug 25 '17 at 18:37

answered Aug 25 '17 at 18:22

James Douglas

3,328
2
22
43

I didn't downvote, but you added nothing from what Quentin had already said – Matthew Ciaramitaro Aug 25 '17 at 18:26
@MatthewCiaramitaro Oh ok. I didn't notice his answer, I was already typing mine. – James Douglas Aug 25 '17 at 18:27
1

@MatthewCiaramitaro I spotted the error and commented on the OP's post you see – James Douglas Aug 25 '17 at 18:27

score -3 · Answer 3 · answered Aug 25 '17 at 18:19

-3

I think it should be window.open=links[Math.floor(Math.random()*max)]

answered Aug 25 '17 at 18:19

Alex Isac

1

3

that won't work try running it in the console before you answer – Matthew Ciaramitaro Aug 25 '17 at 18:29

how can i make a random link open in a new tab?

3 Answers3