table doesn't get updated

Question

I want to insert data into returnlist table and update the material table when i click the insert button. insertion works fine but the material table doesn't get updated.

<?php

    if(isset($_POST['submit'])){


    $Item = $_POST['Item'];
    $Quantity = $_POST['Quantity'];
    $Location = $_POST['Location'];
    $ReDate = $_POST['ReDate'];

    $query = mysql_query("INSERT INTO returnlist(Item,Quantity,Location,ReDate) VALUES ('$Item','$Quantity','$Location' ,'$ReDate')",$connection);
    $query = mysql_query("UPDATE material SET Quantity=Quantity + '$Quantity' WHERE 'Item'='$Item'", $connection);
    }

?>

More clarity is needed. When you click the button, do you send your request over ajax? — Oniya Daniel, Oct 06 '17 at 05:38
Assuming that the query is correct, have you check `$item`'s value if it is really what you expect? Or at least tried the query in `phpmyadmin` *(if you are using it)* ? — Carl Binalla, Oct 06 '17 at 05:39
One more thing, if you are using variables inside a string, use `"` rather than `'`, so that the variable's value is used rather than using it literally — Carl Binalla, Oct 06 '17 at 05:40
Please don't use mysql_* . Either use mysqli or pdo. This has been repeated soo many times. Also never go live in production with this 'code'. It's amazing nobody is talking about the massive security vulnerabilities in the above code — Rotimi, Oct 06 '17 at 05:41
You need to concatenate the data values with the Sql string values. — Tuhin Subhra Dey, Oct 06 '17 at 05:42

score 3 · Accepted Answer · answered Oct 06 '17 at 05:39

3

try this format

$query = mysql_query("UPDATE material SET `Quantity` = `Quantity` + '".$Quantity."' WHERE `Item` = '".$Item."'", $connection);

answered Oct 06 '17 at 05:39

AZinkey

5,209
5
28
46

it works! thank you! – Lisa234 Oct 06 '17 at 05:42
the you can accept my answer as well – AZinkey Oct 06 '17 at 05:43
1

Maybe advice OP not to use mysql_* – Rotimi Oct 06 '17 at 05:45

score 0 · Answer 2 · answered Oct 06 '17 at 05:41

0

Remove single quote from item and change it to backtick.

UPDATE material SET Quantity=Quantity + '$Quantity' WHERE 'Item'='$Item'

change to use backtick

"UPDATE material SET Quantity=Quantity + '$Quantity' WHERE `Item`='$Item'"

or remove it

"UPDATE material SET Quantity=Quantity + '$Quantity' WHERE Item='$Item'"

answered Oct 06 '17 at 05:41

Zamrony P. Juhara

5,222
2
24
40

Maybe advice OP to use prepared statements – Rotimi Oct 06 '17 at 05:47

table doesn't get updated

2 Answers2