while loop with if statement not working

Question

By way of an example I have a txt file that contains a list of dogs, one on each line of the file and then "**" on the last line. I then have the following code to load this into an ArrayList to use in a JComboBox.

This way I can simply add another line in the text box to add another dog.

My example code is as follows

public class test{
static String temp;

public static void main(String[] args) {
List<String> picklistDogs = new ArrayList<String>();
File picklistFile = new File (filePath);
try {
    BufferedReader loadPickList = new BufferedReader (new FileReader(picklistFile));
    while(true) {
        temp = loadPickList.readLine();
        if (temp != "**") {
            picklistDogs.add(temp);
        } else {
            break;
        }
    }
    loadPickList.close();
}
catch(FileNotFoundException e){
    System.out.println("file not found");
}
catch(IOException e){
    System.out.println("file io error");
}
} // END of main
} // END of class test

My problem seams to be that the if statement never triggers the break to exit the while loop.

Any solutions would be appreciated.

I added what I think is the language tag. Please amend if this is not correct. (And do tag the language in future.) — Bathsheba, Oct 17 '17 at 08:49
Thanks guys for all the comments, I found quite a few examples on here that did it the way I did above. Using the `equals` solved my problem. — m ainsworth, Oct 17 '17 at 12:21

score 1 · Answer 1 · answered Oct 17 '17 at 10:18

1

Use !temp.equals("**") .Try below code

if (!temp.equals("**")) {
                picklistDogs.add(temp);
            } else {
                break;
            }

answered Oct 17 '17 at 10:18

A W

1,041
11
18

Thanks a lot Aniket – m ainsworth Oct 17 '17 at 12:19

score 0 · Answer 2 · answered Oct 17 '17 at 09:43

0

In order to compare strings better to use java.lang.String#equals

answered Oct 17 '17 at 09:43

Oleh Linnyk

59
1
13

while loop with if statement not working

2 Answers2