split implementation using vectors and char*

Question

I am trying to split a char* based on a delimiter using nested vectors however the last word of the char* seems to not be added to the vector>

vector<vector<char>> split(char* word, const char de){
    vector<vector<char>> words;
    vector<char> c_word;
    while(*word){
        if(*word == de){
            words.push_back(c_word);
            c_word.clear();
            word++;
            continue;
        }
        c_word.push_back(*word);
        word++;
    }
    return words;
}

Example usage:

int main() {
    char *let = "Hello world!";

    vector<vector<char>> words = split(let, ' ');
    for(int x = 0;x < words.size();x++){
        for(int y = 0;y < words[x].size();y++){
            cout << words[x][y];
        }
        cout << endl;
    }
}

This would print only Hello

can you provide a code with input so one can try it ? www.ideone.com — andre_lamothe, Oct 20 '17 at 19:11
Is there a reason you use `std::vector>` instead of `std::vector`? And `char*` instead of `std::string`? — Some programmer dude, Oct 20 '17 at 19:12
Unless the last char is the delimiter, you will still have a word in `c_word` when the loop is finished. — 001, Oct 20 '17 at 19:12
why not using a std::string and use index of (' ') and cut the string — andre_lamothe, Oct 20 '17 at 19:12
Because it's a class asignment to split a char* without using string — MartinStone, Oct 20 '17 at 19:14
You might want to check this out: https://stackoverflow.com/questions/236129/the-most-elegant-way-to-iterate-the-words-of-a-string — NathanOliver, Oct 20 '17 at 19:18

score -1 · Answer 1 · answered Oct 20 '17 at 19:44

Here is a full working code with multiple delimeters

vector<vector<char>> split(char* word, const char de) {
    vector<vector<char>> words;
    vector<char> c_word;
    int index = 0;
    int j = 0;
    char *temp = word;
    int numspaces = 0;
    while (*word) {
        if (*word == de) {
            words.push_back(c_word);
            c_word.clear();
            word++;
            j = index;
            numspaces++;
        }
        index++;
        c_word.push_back(*word);
        word++;
    }
    j +=numspaces;
    char *sub = &temp[j];
    c_word.clear();
    while (*sub)
    {
        c_word.push_back(*sub);
        sub++;
    }
    words.push_back(c_word);
    return words;
}
void main()
{
    vector<vector<char>> result = split("Hello World! Ahmed Saleh", ' ');

}

score -2 · Answer 2 · answered Oct 20 '17 at 19:23

For anyone else wondering how to do this implementation using char* instead of string. What my code is missing is a final add of c_word to words since the while is already over when it reaches the null terminator and doesn't add the final word, this is the fixed code:

   vector<vector<char>> split(char* word, const char de){
    vector<vector<char>> words;
    vector<char> c_word;
    while(*word){
        if(*word == de){
            words.push_back(c_word);
            c_word.clear();
            word++;
            continue;
        }
        c_word.push_back(*word);
        word++;
    }
    words.push_back(c_word);
    return words;
}

split implementation using vectors and char*

2 Answers2