Getting an InvalidOperationException when using a concrete class as a Controller property .NET Core

Question

When passing MailService to my Controller's constructor my app throws a System.InvalidOperationException. However, when I switch it out for the interface, it works. What is the reason for this?

In Startup.cs

services.AddScoped<IMailService, MailService>();

In my Controller

private IMailService MailService { get; }

public AccountController(UserManager<ApplicationUser> userManager, SignInManager<ApplicationUser> signInManager, MailService mailService)
{
    if (userManager == null)
        throw new ArgumentNullException(nameof(userManager));

    if (signInManager == null)
        throw new ArgumentNullException(nameof(signInManager));

    if (mailService == null)
        throw new ArgumentNullException(nameof(mailService));

    this.UserManager = userManager;
    this.SignInManager = signInManager;
    this.MailService= mailService;
}

Many thanks!

Your code (after the edit) looks OK so better provide the exact error message and the top of the stack trace. — H H, Oct 25 '17 at 11:41

Igor · Answer 1 · 2017-10-25T11:35:14.700

2

services.AddScoped<IMailService, MailService>();

Because of that line. You are telling the DI service to inject an instance of MailService in the constructors when it encounters a parameter in the constructor of type IMailService.

You have nothing defined for injecting (replacing) instances of type MailService.

What you have now is good practice, do not change it. You want to program against interfaces when possible. This is also called interface based programming and there are many benefits.

See also a possibly related question: What does it mean to "program to an interface"?

edited Oct 25 '17 at 11:35

answered Oct 25 '17 at 11:29

Igor

60,821
10
100
175

I realised/learned this after! To clarify, you're saying I was asking for the service instead of the interface, so the DI container was only setup to give me a MailService when I asked for an IMailService? – Dninja Dec 09 '17 at 12:40

score 0 · Answer 2 · answered Oct 25 '17 at 11:29

I noticed this too. Back when we used Unity for DI, it would be fine with resolving a concrete class you requested, even if you had not specifically added it to the container.

With .NET Core dependency injection, it requires that you specifically declare the services you are injecting. Even though it could resolve your concrete class, I'm guessing the decision was made at some point in the development process to require this. So your code would work if you did:

services.AddScoped<MailService>();

Getting an InvalidOperationException when using a concrete class as a Controller property .NET Core

2 Answers2