if else statement using JAVASCRIPT

Question

How can I correct this code using javascript and html. Thanks in advance! please help me out of this problem.

<input type="text" id="text1">
<input type="text" id="text2">
<input type="submit" onclick="submit()">

<script type="text/javascript">
    function submit() {
        var q = document.getElementById('text1');
        var w = document.getElementById('text2');

        if (q > w) {
            console.log('q is greaterthan in w');
        } else{
            console.log('q is less that in w');
        }

    }
</script>

What are you expecting to have your code do, and what's happening instead? — Chris Forrence, Oct 31 '17 at 15:32
why do you -rep me :( I dont really know what is the syntax or code here :( — pacificskybeachresort, Oct 31 '17 at 15:33
What is the problem? What does the console tell you? Are you sure `q` and `w` can be compared using the operator `>`? — msfoster, Oct 31 '17 at 15:33
Possibly a duplicate of [this](https://stackoverflow.com/questions/31613748/why-cant-i-call-a-function-named-clear-from-an-onclick-attribute/31613889#31613889), but the question lacks a clear problem statement. — Quentin, Oct 31 '17 at 15:33

Constantin Groß · Accepted Answer · 2017-10-31T15:44:03.900

-1

You are comparing the DOM elements (input fields) themselves, not their values. In order to get the values and compare those, you have to actually get the .value property and treat them as Numbers (float or integer or whatever it's going to be).

function submit() {
    var q = parseFloat(document.getElementById('text1').value);
    var w = parseFloat(document.getElementById('text2').value);

    if (q > w) {
        console.log('q is greater than w');
    }
    else
    {
        console.log('q is less or equal than w');
    }
}

<input type="text" id="text1">
<input type="text" id="text2">
<input type="submit" onclick="submit()">

edited Oct 31 '17 at 15:44

answered Oct 31 '17 at 15:35

Constantin Groß

10,719
4
24
50

Not me downvoting, but you have a spelling error in the second parseFLoat – msfoster Oct 31 '17 at 15:40
Already noticed and fixed after dealing with this nonsense! ;) – Constantin Groß Oct 31 '17 at 15:41
@Connum thats what I mean bro, thankyou so much! :D – pacificskybeachresort Oct 31 '17 at 15:46
Glad to help. Even if there are obviously people thinking that my answer is not helpful at all... If you're expecting the textbox to hold text, not numbers, then just don't use the `parseFloat()`. But you still have to get the `.value` in order to compare the string. – Constantin Groß Oct 31 '17 at 15:48
what should I change in the parseFloat? Sorry for my litte problem for you, im really a beginner in this javascript. – pacificskybeachresort Oct 31 '17 at 15:55
just leave the `parseFloat()` out completely. It just converts a string to a float number. – Constantin Groß Oct 31 '17 at 15:59

Kenji Mukai · Answer 2 · 2017-10-31T15:43:02.617

-2

You have to get the value of the input like this: document.getElementById('text1').value

function submit() {
    var q = document.getElementById('text1').value;
    var w = document.getElementById('text2').value;

    if (q > w) {
        console.log('q is greaterthan in w');
    }
    else
    {
        console.log('q is less that in w');
    }

}

edited Oct 31 '17 at 15:43

answered Oct 31 '17 at 15:33

Kenji Mukai

599
4
8

Why do I have downvotes if this is a helpful answer? Haha. – Kenji Mukai Oct 31 '17 at 15:51
Just your comment now - it happened to my answer as well and just happened again in another question. The answer to why people do this is: Because some people here are idiots. Maybe they have low self-esteem or other problems in their real lifes, who knows. See also: https://meta.stackoverflow.com/questions/255459/is-it-okay-to-downvote-answers-to-bad-questions – Constantin Groß Nov 02 '17 at 18:15

if else statement using JAVASCRIPT

2 Answers2