0

This code is supposed to insert a given int after and a given int before a linked list. However, when I pass the arguments in main, they do not store the values in commands insAfter and insBefore, and just return 0. I am guessing it has to do with the integer, but when I had the user input the value in the actual function and set it to the same thing "n" is set to and it worked.

struct node {
  int data;
  char *item;
  struct node* next;
};

struct node* root = NULL;

void insAfter();
void insBefore();


//Main
void main () {


}



//Command Insert After
void insAfter(int n) {
  struct node* temp;
  temp = (struct node*)malloc(sizeof(struct node));

  n = temp->data;
  temp->next = NULL;

  if(root==NULL) {
    root = temp;
    printf("Text inserted at beginning\n");

  }
  else {
    struct node* p;
    p = root;

    while(p->next != NULL) {
      p = p->next;
    }
    p->next = temp;
      printf("Ok\n");

  }
}

//Command Insert Before
void insBefore(int n) {
  struct node* temp;
  temp = (struct node*)malloc(sizeof(struct node));
  n = temp->data;
  temp->next=NULL;

  if (root == NULL) {
    root = temp;
    printf("Text inserted at beginning\n");
    fflush(stdout);
  }
  else {
    temp->next=root;
    root = temp;
    printf("Ok\n");
    fflush(stdout) ;
  }

}
  • `scanf("%s",&command)` should be replaced with `scanf("%s",command)`. [This](https://stackoverflow.com/q/5406935/5987698) might help. – GoodDeeds Nov 04 '17 at 20:10
  • With `char command[4];` followed by `scanf("%s", &command);` (which should be `scanf("%s", command);`) you are asking for trouble with such a small array and no input length restriction. – Weather Vane Nov 04 '17 at 20:17
  • Significantly more debugging should really be done by you before posting. – David Hoelzer Nov 04 '17 at 20:49

1 Answers1

2

There's a small mistake in ina() and inb().

The statement

n = temp->data;

should be replaced with

temp->data = n;

Instead of setting the input to the list, you are overwriting n, and not modifying the data of the list node at all.

GoodDeeds
  • 7,956
  • 5
  • 34
  • 61