Clicking link image within does not log

Question

I have two links that have different structure.

<div id="content">    
 <a href="javascript:void(0)" data-uri="https://stackoverflow.com/questions/ask">

and

 <a href="javascript:void(0)" data-uri="https://stackoverflow.com/questions/ask">
  <img src="https://www.gravatar.com/avatar/084f45fb1ccb4bd208ad48dbffcd502f?s=48&d=identicon&r=PG">
 </a>
</div>

I have this function that should log data-uri by clicking <a> element.

var clickHandler = "click";

if ('ontouchstart' in document.documentElement) {
    clickHandler = "touchstart";
}

$(document).on(clickHandler, '#content a', function() {
        href = $(this).data("uri");
        console.log(href);
});

For some reason link with image just does not work. Nothing get logged.

PS. clickHandler variable is there adapt if page is viewed by mobile device that has touch feature.

are you sure that onclick actually fired? maybe all your links are not in a #content — 2oppin, Nov 08 '17 at 08:50
I am sure since the first example is working. Both are inside #content. Let me edit the question content. — Jaakko Uusitalo, Nov 08 '17 at 08:51

sumit sharma · Answer 1 · 2017-11-08T09:01:34.640

0

I think this should work

delete this portion

if ('ontouchstart' in document.documentElement) {
 clickHandler = "touchstart";
}

and add this

$(document).on('touchstart click', 'a#content', function(event){

based on answer

How to bind 'touchstart' and 'click' events but not respond to both?

edited Nov 08 '17 at 09:01

answered Nov 08 '17 at 08:53

sumit sharma

698
5
16

This almost works. Now I am getting href from both links, but the one without image is firing twice. Each click on first example logs twice. – Jaakko Uusitalo Nov 08 '17 at 08:56

score 0 · Answer 2 · edited Sep 04 '18 at 02:48

0

Works fine for me.

You can go through this: http://jsfiddle.net/PpXz5/4/

The code:

$("#content a").on("click", function() {
        href = $(this).data("uri");
        console.log(href);
});

edited Sep 04 '18 at 02:48

Pang

9,564
146
81
122

answered Nov 08 '17 at 09:05

Sushant Bassi

364
3
16

Clicking link image within does not log

2 Answers2