onNavigationItemSelected not being called for Bottom Navigation Bar

Question

I'm trying to implement a bottom nav bar that changes fragments when the nav items are clicked. However, when I click on the nav bar items, the fragments don't change. Using log.d, I noticed onNavigationItemSelected is not being called. How do I fix this?

To note, the startFeedFragment, startScheduleFragment, & startSettingsFragmentare implemented the same way and they work for the buttons in the toolbar. I also referenced this tutorial and this question for help.

MainActivity.java

public class MainActivity extends AppCompatActivity implements BottomNavigationView.OnNavigationItemSelectedListener {

protected void onCreate(Bundle savedInstanceState)
    {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);
        Toolbar toolbar = (Toolbar) findViewById(R.id.toolbar);
        setSupportActionBar(toolbar);
        setUpRecycler();
        startFeedFragment();

        BottomNavigationView bottomNavBar = (BottomNavigationView) findViewById(R.id.navigation);
        bottomNavBar.bringToFront();
        bottomNavBar.setOnNavigationItemSelectedListener(this);
    }

    @Override
    public boolean onNavigationItemSelected(@NonNull MenuItem item) {
        Log.d("NAV BAR", "onNavigationItemSelected hit");
        switch (item.getItemId()) {
            case R.id.feedMenu:
                startFeedFragment();
                Log.d("NAV BAR", "feed");
                break;
            case R.id.myScheduleMenu:
                startScheduleFragment();
                Log.d("NAV BAR", "schedule");
                break;
            case R.id.settingsMenu:
                startSettingsFragment();
                Log.d("NAV BAR", "settings lol");
                break;
            default:
                Log.d("NAV BAR", "false");
                return false;
        }
        return true;
    }

   /**
     * Switches out the fragment for {@link FeedFragment} and sets an appropriate title. startScheduleFragmens & startSettingsFragment are implemented the same way
     */
    private void startFeedFragment()
    {
        FragmentTransaction transaction = getSupportFragmentManager().beginTransaction();
        transaction.replace(R.id.fragmentContainer, new FeedFragment());
        transaction.commit();
        getSupportActionBar().setTitle(R.string.title_fragment_feed);
    }
}

Snippet from xml file

    <android.support.constraint.ConstraintLayout
        android:layout_width="match_parent"
        android:layout_height="match_parent"
        app:layout_behavior="@string/appbar_scrolling_view_behavior">

        <FrameLayout
            android:id="@+id/fragmentContainer"
            android:layout_width="0dp"
            android:layout_height="0dp"
            app:layout_constraintBottom_toTopOf="@+id/navigation"
            app:layout_constraintEnd_toEndOf="parent"
            app:layout_constraintStart_toStartOf="parent"
            app:layout_constraintTop_toTopOf="parent" />

        <android.support.design.widget.BottomNavigationView
            android:id="@+id/navigation"
            android:layout_width="match_parent"
            android:layout_height="wrap_content"
            app:itemBackground="@android:color/white"
            app:itemIconTint="@color/colorPrimaryDark"
            app:itemTextColor="@color/colorPrimaryDark"
            app:layout_constraintBottom_toBottomOf="parent"
            app:layout_constraintEnd_toEndOf="parent"
            app:layout_constraintStart_toStartOf="parent"
            app:menu="@menu/bottom_nav"
            android:elevation="8dp"/>
    </android.support.constraint.ConstraintLayout>

</android.support.design.widget.CoordinatorLayout>

score 0 · Accepted Answer · answered Nov 14 '17 at 04:40

Solved! It was because I had set the buttons in the menu to android:enabled="false". That meant they couldn't be pressed, which is why onNavigationItemSelected wasn't being called. I set all buttons to android:enabled="true" to fix this.

Correct code for bottom_nav.xml

<?xml version="1.0" encoding="utf-8"?>
<menu xmlns:android="http://schemas.android.com/apk/res/android">
    <item android:id="@+id/bottom_nav_my_schedule"
        android:title="@string/menu_my_schedule"
        android:icon="@drawable/ic_event_available_white_24dp"
        android:enabled="true"/> <!--make sure enabled is set to true!-->
    <item android:id="@+id/bottom_nav_feed"
        android:title="@string/menu_feed"
        android:icon="@drawable/ic_view_list_white_24dp"
        android:enabled="true" /> <!--make sure enabled is set to true!-->
    <item android:id="@+id/bottom_nav_settings"
        android:title="@string/menu_settings"
        android:icon="@drawable/ic_settings_white_24dp"
        android:enabled="true"/> <!--make sure enabled is set to true!-->
</menu>

score 0 · Answer 2 · answered Jun 29 '21 at 23:40

As for me the problem was when my activity main layout was LinearLayout, so I've solved it by changing it to RelativeLayout, I have absolutely no thoughts why it's working, because RelativeLayout layouts reply only for elements location, not its view or something else, but it's working.

<RelativeLayout
  xmlns:android="http://schemas.android.com/apk/res/android"
  xmlns:app="http://schemas.android.com/apk/res-auto"
  android:layout_width="match_parent"
  android:layout_height="match_parent"
  android:orientation="vertical"
  >
  
  <android.support.v4.view.ViewPager
    android:id="@+id/view_pager"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    />
  
  <android.support.design.widget.BottomNavigationView
    android:id="@+id/bottom_navigation"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:layout_alignParentBottom="true"
    app:itemBackground="@drawable/selector"
    android:background="@color/white"
    app:menu="@menu/menu_bottom"
    app:itemIconTint="@drawable/menu_trainings"
    app:labelVisibilityMode="unlabeled"
    />
    
</RelativeLayout>

onNavigationItemSelected not being called for Bottom Navigation Bar

2 Answers2