Why is the Parse error is occured in this code? PHP

Question

I am working on Magento project.There I have a controller which is a php file.I want to write a JavaScript function inside that php file. This is the function which results in the error,

 public function verifyPinAction()
         {
           $data = $this->getRequest()->getPost();
             echo "<script type='text/javascript'>
           var datastring=<?php echo $data['pin'];?>;
           $.ajax({
type: 'POST',
url: 'http://xxxxx.com/xxxxxx/ErrorProcessing1.php',
data : datastring,
//dataType: 'json',

success: function(html) {



   //alert(html);


   if(html=='wrong text entered')
  {
    <?php Mage::getSingleton('core/session')->addError('Invalid Pin Number');
                  $this->_redirect('enterpintoverify'); ?>
  } 
  else{
    <?php Mage::getSingleton('core/session')->addSuccess('Your Email is verified');
                $this->_redirect('enterpintoverify');?>
  } 


}
});
           </script>
           ";

         }

It gives the following error

Parse error: syntax error, unexpected '' (T_ENCAPSED_AND_WHITESPACE), expecting identifier (T_STRING) or variable (T_VARIABLE) or number (T_NUM_STRING) in /home/xxxxx/public_html/newtradesdev/app/code/local/Customer/Register/controllers/IndexController.php on line 65

Line 65 refers to var datastring=<?php echo $data['pin'];?>; Can someone tell me where have I gone wrong?

I have used xxxx marks beacause I am working on hosted site.Please skip the urls.

Don't use `addError('Invalid Pin Number'); $this->_redirect('enterpintoverify'); ?>` to execute client side right? That will execute on generation. — chris85, Nov 17 '17 at 11:21

score 1 · Accepted Answer · answered Nov 17 '17 at 11:20

Change your echo to this instead:

public function verifyPinAction()
{
   $data = $this->getRequest()->getPost();
?>
<!--HTML STARTS HERE-->
<script type='text/javascript'>
           var datastring=<?php echo $data['pin'];?>;
           $.ajax({
type: 'POST',
url: 'http://xxxxx.com/xxxxxx/ErrorProcessing1.php',
data : datastring,
//dataType: 'json',

success: function(html) {



   //alert(html);


   if(html=='wrong text entered')
  {
    <?php Mage::getSingleton('core/session')->addError('Invalid Pin Number');
                  $this->_redirect('enterpintoverify'); ?>
  } 
  else{
    <?php Mage::getSingleton('core/session')->addSuccess('Your Email is verified');
                $this->_redirect('enterpintoverify');?>
  } 


}
});
           </script>
<!--HTML ENDS HERE-->
<?php

}

?>

This presents more readable code and will not cause any errors either.

Thanks .It fix the issue.Cheers – sadeee nadeee Nov 20 '17 at 05:18 — sadeee nadeee, Nov 20 '17 at 05:18

score 1 · Answer 2 · answered Nov 17 '17 at 11:26

1

Try using concatenate php code in your echo

echo "<script type='text/javascript'>
                        var datastring=".$data['pin'].";
                        $.ajax({....

answered Nov 17 '17 at 11:26

SelVazi

10,028
2
13
29

Thanks.I forgot about concatenation – sadeee nadeee Nov 20 '17 at 05:20

score 1 · Answer 3 · edited Nov 17 '17 at 12:12

1

It may happen due to parse error. Try concatenation for PHP Code.

var datastring=".$data['pin'].";

edited Nov 17 '17 at 12:12

Tschallacka

27,901
14
88
133

answered Nov 17 '17 at 11:26

Harry

11
2

Thanks.I forgot about concatenation – sadeee nadeee Nov 20 '17 at 05:20

Why is the Parse error is occured in this code? PHP

3 Answers3