IllegalStateException when trying to show dialog fragment

Question

I get IllegalStateException on Google-Play Console which I can not reproduce and I don't understand what is the issue.

Here is the log from Google-Play Console

java.lang.RuntimeException: 
    at com.loopj.android.http.AsyncHttpResponseHandler.onUserException (AsyncHttpResponseHandler.java:304)
    at com.loopj.android.http.AsyncHttpResponseHandler.handleMessage (AsyncHttpResponseHandler.java:395)
    at com.loopj.android.http.AsyncHttpResponseHandler$ResponderHandler.handleMessage (AsyncHttpResponseHandler.java:510)
    at android.os.Handler.dispatchMessage (Handler.java:102)
    at android.os.Looper.loop (Looper.java:148)
    at android.app.ActivityThread.main (ActivityThread.java:5441)
    at java.lang.reflect.Method.invoke (Native Method)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:738)
    at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:628)

Caused by: java.lang.IllegalStateException: 
    at android.support.v4.app.FragmentManagerImpl.enqueueAction (FragmentManager.java:1515)
    at android.support.v4.app.BackStackRecord.commitInternal (BackStackRecord.java:638)
    at android.support.v4.app.BackStackRecord.commit (BackStackRecord.java:617)
    at android.support.v4.app.DialogFragment.show (DialogFragment.java:139)
    at com.example.eliran.forum.ForumFragment.regularTopic (ForumFragment.java:240)
    at com.example.eliran.forum.ForumFragment.enterTopic (ForumFragment.java:225)
    at com.example.eliran.forum.ForumFragment$13.onSuccess (ForumFragment.java:620)
    at com.loopj.android.http.TextHttpResponseHandler.onSuccess (TextHttpResponseHandler.java:118)
    at com.loopj.android.http.AsyncHttpResponseHandler.handleMessage (AsyncHttpResponseHandler.java:351)

According to the logs that I've attached, the flow is like this:

The fragment created and calls to function which uses AsyncHttpClient.
AsyncHttpClient done with success result which return json object.
AsyncHttpClient success calls to enterTopic with the json.
enterTopic calls to regularTopic.

In this function (regularTopic) it happens. Here is the function:

public void regularTopic(ForumTopic forumTopic, int positionInArray) {
    FragmentManager fm = getChildFragmentManager();
    ForumTopicDialogFragment dialogFragment = new 
    ForumTopicDialogFragment();
    dialogFragment.setTargetFragment(this,100);
    Bundle bundle = new Bundle();
    bundle.putInt("posInArray", positionInArray);
    bundle.putSerializable("topic", forumTopic);
    dialogFragment.setArguments(bundle);
    dialogFragment.show(fm, ""); }

Here is the AsyncHttpClient request (onSuccess should run from the UIThread):

AsyncHttpClient client = new AsyncHttpClient();
String url = TheFinals.HOST + "/topics/" + id;
client.get(url, new TextHttpResponseHandler() {
    @Override
    public void onFailure(int statusCode, Header[] headers, String responseString, Throwable throwable) {

    }

    @Override
    public void onSuccess(int statusCode, Header[] headers, String responseString) {
        try {
            JSONArray topic = new JSONArray(responseString);
            if (topic.length() > 0) {
                JSONObject jsonObject = topic.getJSONObject(0);
                ForumTopic forumTopic = new ForumTopic(jsonObject.getInt("id"), jsonObject.getInt("userid"),
                        jsonObject.getString("content"), jsonObject.getString("title"), jsonObject.getString("firstname"),
                        jsonObject.getString("time"), jsonObject.getInt("icon"), jsonObject.getString("fbid")
                        , jsonObject.getInt("status"), jsonObject.getInt("anonymous"), jsonObject.getInt("catid"), jsonObject.getString("picture"));
                ForumFragment.this.enterTopic(forumTopic, -1);
            }
        } catch (JSONException e) {
            e.printStackTrace();
        }

    }

});

Can someone help please? First I need to reproduce this issue in my phone :\

Are you calling regularTopic on the main thread? could you post the code when you call to regularTopic? — diegoveloper, Nov 19 '17 at 23:06
@diegoveloper I edited my post - attached the code. enterTopic called from onSuccess after the asynctask ends. — Eliran Tutia, Nov 19 '17 at 23:24

score 11 · Accepted Answer · answered Nov 21 '17 at 21:36

11

This issue is related to this bug. I solved it by override the show method in my dialog fragment:

@Override
public void show(FragmentManager manager, String tag) {
    try {
        FragmentTransaction ft = manager.beginTransaction();
        ft.add(this, tag).addToBackStack(null);
        ft.commitAllowingStateLoss();
    } catch (IllegalStateException e) {
        Log.e("IllegalStateException", "Exception", e);
    }

}

answered Nov 21 '17 at 21:36

Eliran Tutia

706
1
6
22

But with this solution(`commitAllowingStateLoss`), if we're passing something to that fragment, we will lose it, if `IllegalStateException` occurs. – Dr.jacky Jun 28 '19 at 08:41

score 0 · Answer 2 · answered Nov 19 '17 at 23:29

0

Try calling enterTopic after 500ms delay:

//declare this as global variable on your activity
final Handler handler = new Handler();


handler.postDelayed(new Runnable() {
  @Override
  public void run() {
    ForumFragment.this.enterTopic(forumTopic, -1);
  }
}, 500);

answered Nov 19 '17 at 23:29

diegoveloper

93,875
20
236
194

do you have any clue how to reproduce this issue before Ill try to fix it? – Eliran Tutia Nov 19 '17 at 23:34
I had a similar issue but only happens in some devices :/ – diegoveloper Nov 19 '17 at 23:35
Caused by: java.lang.IllegalStateException: – diegoveloper Nov 19 '17 at 23:38
Yes, I mean the specific issue.Do you think ForumFragment.this isnt created yet? – Eliran Tutia Nov 19 '17 at 23:38
Probably, it's very weird because as I said it only happens in some devices and Android OS versions – diegoveloper Nov 19 '17 at 23:39
In google-play console I see it happens in any kind of device and Android OS (also new devices). Weird :\ – Eliran Tutia Nov 19 '17 at 23:41
Could you test on your Android emulator(check version of the devices crash) to see if you can reproduce the issue ? – diegoveloper Nov 19 '17 at 23:42
Any kind. start from OS 5 to 8. Galaxy 5 to Pixel 2. No clue how to reproduce. – Eliran Tutia Nov 19 '17 at 23:44
check this: https://stackoverflow.com/questions/11900785/illegalstateexception-fragment-support-library – diegoveloper Nov 19 '17 at 23:46

IllegalStateException when trying to show dialog fragment

2 Answers2