How to put constant in an array in php

Question

I need to get the count of the authors on the WordPress page. First of all, this question does not touch WordPress syntax or something more about this CMS. The question is strictly about php algorithms.

So, I have the 10 elements get by the method foreach. And now I must put they in the array $getcount to get they count by array method count in php language.

For some reasons method count does not work, because I always get the else result.

<?php foreach ($coauthors_meta as $key ) :  
    $getcount = array($key);
    if (count($getcount) > 1) echo '<div class="privv">Hello!</div>';
    else echo 'Empty';
<?php endforeach; ?>

P.S. Array method foreach ($coauthors_meta as $key ) work fine and dispay all authors on the page. So the problem is hidding in other thing.

Possible duplicate of [How to add elements to an empty array in PHP?](https://stackoverflow.com/questions/676677/how-to-add-elements-to-an-empty-array-in-php) — mickmackusa, Jan 18 '18 at 21:58

ryantxr · Accepted Answer · 2018-01-18T20:59:52.417

5

You are creating an array with one element every time and then checking to see if it has more than one element.

<?php foreach ($coauthors_meta as $key ) :  
    $getcount = array($key); // << always makes an array with one element
    // count will always be 1 so the else condition will always happen
    if (count($getcount) > 1) echo '<div class="privv">Hello!</div>';
    else echo 'Empty';
<?php endforeach; ?>

Change :

$getcount = array($key);

To

$getcount[] = $key;

edited Jan 18 '18 at 20:59

answered Jan 18 '18 at 20:57

ryantxr

4,119
1
11
25

so how can I fix that? – Sviat Kuzhelev Jan 18 '18 at 20:58

Alive to die - Anant · Answer 2 · 2018-01-18T21:05:11.350

Problem:- You are assigning only single value to $getcount variable inside foreach()(variable re-created again and again and the current value assigned to it).

Solution:- Reconstruct logic like below:-

//empty array declaration
<?php $getcount = [];?>
<?php foreach ($coauthors_meta as $key ) :  
    $getcount[] = $key;//assign values to the array
    if (count($getcount) > 1) echo '<div class="privv">Hello!</div>';
    else echo 'Empty';
<?php endforeach; ?>

score 1 · Answer 3 · answered Jan 18 '18 at 21:03

What you are doing wrong (as it seems), is that you are creating a new array every foreach loop and assigning 1 of the keys into it:

<?php foreach ($coauthors_meta as $key ) :  
    $getcount = array($key); // <---- You are creating a new array!
    if (count($getcount) > 1) echo '<div class="privv">Hello!</div>';
    else echo 'Empty';
<?php endforeach; ?>

To fix this, simply define your array before the foreach, and push the value to the array:

<?php 
    $getcount = array();
    foreach ($coauthors_meta as $key ) :  
    $getcount[] = $key;
    if (count($getcount) > 1) echo '<div class="privv">Hello!</div>';
    else echo 'Empty';
<?php endforeach; ?>

And now it should work! :)

How to put constant in an array in php

3 Answers3