7

I have a @Service class which has a @Transactional method that calls another @Transactional method on the another service. Something like that:

@Service
public class AService {
  @Autowired
  BService b;
  @Autowired
  ARepository aRepo;

  @Transactional
  public void methodOne(){
    try{
      b.methodTwo();
    }catch(RuntimeException e){}
    aRepo.save(new A());
  }

} 

@Service
public class BService{

    @Transactional
    public void methodTwo(){
      if(true)
        throw new RuntimeException();
    }

}

I expect that A entity will be insert, but if any nested transaction throw exception insert will reject even this exception was handled at AService.methodOne().

I can annotate methodTwo() with @Transactional(propagation = Propagation.REQUIRES_NEW). But it will beat performance.

JoeyD
  • 19
  • 3
the-red-paintings
  • 75
  • 1
  • 5
  • There is no nested transaction there is a single one. If you want separate transactions you ned to annotate the other one with `REQUIRES_NEW`. Yes that is a performance impact as it starts a new tx. – M. Deinum Jan 26 '18 at 13:33
  • Have this case another more elegant solution ? – the-red-paintings Jan 26 '18 at 13:39
  • No. You either commit everything or rollback everything... You cannot partially commit stuff that would beat the ACID properties of a transaction. – M. Deinum Jan 26 '18 at 13:40
  • If i move try-catch block into methodTwo() A entity insert successfully. But in my real methodOne i have a lot of method calls, and some of them is required for bussines logic. – the-red-paintings Jan 26 '18 at 13:46
  • did you find the solution? I'm also having the same problem. – Vishal Patel May 26 '22 at 09:06

1 Answers1

1

If you don't want to rollback your transaction from methodOne after some exception happens in the methodTwo, you can add annotate methodOne with @Transactional(noRollbackFor = {RuntimeException.class}). But please be aware that this is a bit of slippery slope and think twice if you really want to do it.

TheJavaGuy-Ivan Milosavljević
  • 1,803
  • 2
  • 16
  • 24
  • methodOne() has a lot of another service method calls, and this methods calls not only in AService. I want this behaviour only in AService. – the-red-paintings Jan 26 '18 at 13:55