Kotlin - Preference.setOnPreferenceClickListener

Question

I'm trying to add an onPreferenceClickListener within my SettingsFragment and if I do it like this:

signOutPref.setOnPreferenceClickListener(object: Preference.OnPreferenceClickListener {
           override fun onPreferenceClick(preference: Preference?): Boolean {
                    val signOutIntent = Intent(activity, SignInActivity::class.java)
                    startActivity(signOutIntent)
                    return true
                }
            })

It works perfectly while giving a warning:

Use property access syntax

While if I write it like this:

signOutPref.setOnPreferenceClickListener {
                val signOutIntent = Intent(activity, SignInActivity::class.java)
                startActivity(signOutIntent)
                return true
            }

which should be the exactly the same thing and it's the best way to do it, I get a:

The Boolean literal does not conform to the expected type Unit

on the return true statement.

What am I missing? Is the second way to do it different than the first? How do I get rid of this error?

1

remove the `return` keyword – s1m0nw1 Feb 17 '18 at 09:25

s1m0nw1 · Accepted Answer · 2018-02-17T09:37:44.077

In a lambda, the last statement automatically becomes the returned value unless it's return type is inferred as Unit. So simply remove return.

signOutPref.setOnPreferenceClickListener {
   val signOutIntent = Intent(activity, SignInActivity::class.java)
   startActivity(signOutIntent)
   true
}

The documentation says:

A lambda expression is always surrounded by curly braces, parameter declarations in the full syntactic form go inside curly braces and have optional type annotations, the body goes after an -> sign. If the inferred return type of the lambda is not Unit, the last (or possibly single) expression inside the lambda body is treated as the return value.

Thanks a lot, I was missing this part, still gotta get my head around lambda expressions :) — Daniele, Feb 17 '18 at 11:39

score 1 · Answer 2 · edited Feb 17 '18 at 11:41

1

You have to use return@setOnPreferenceClickListener true.

Explanation

Quoting from this anser:

In Kotlin, the return@label syntax is used for specifying which function among several nested ones this statement returns from.

edited Feb 17 '18 at 11:41

user2340612

10,053
4
41
66

answered Feb 17 '18 at 09:25

karandeep singh

2,294
1
15
22

or you can just remove `return` altogether as mentioned in one of the comment – karandeep singh Feb 17 '18 at 09:27

Kotlin - Preference.setOnPreferenceClickListener

2 Answers2

Explanation