How to fix 'Line Length Violation: Line should be 120 characters or less' - SwiftLint

Question

How to fix Line Length Violation?

Relevant part of alert message that isn't allowed due to Line Length Violation: message: NSLocalizedString("\nYou will be requested to Use %@ to Sign In. %@ doesn't share any information about you. The permission is required to post your Live Video.", ⚠ Line should be 120 characters or less: currently 208 characters (line_length)

Well, shorten the line or disable the warning (clearly explained at https://github.com/realm/SwiftLint/blob/master/README.md#disable-rules-in-code) — Martin R, Feb 24 '18 at 18:17
@matt the same way, the question seems to be hard to understand, Martin did answer it though — Yatko, Mar 09 '18 at 18:03

Rob Napier · Accepted Answer · 2018-02-24T18:29:14.387

34

Make the line shorter:

message: NSLocalizedString(
    ["\nYou will be requested to Use %@ to Sign In. ",
    "%@ doesn't share any information about you. The ",
    "permission is required to post your Live Video."].joined()
)

or better, using vacawama's multi-line solution:

let message = 
    """

    You will be requested to Use %@ to Sign In. \
    %@ doesn't share any information about you. \
    The permission is required to post your Live Video.
    """

That's a generic solution, but isn't really appropriate for NSLocalizedString because it breaks tools that scan for localized strings like genstrings.

Your other solution is to turn off the warning for that line by adding a disable on the line immediately before:

// swiftlint:disable:next line_length

See Disable rules in code for full details on disabling swiftlint rules.

edited Feb 24 '18 at 18:29

answered Feb 24 '18 at 18:18

Rob Napier

286,113
34
456
610

8

If you end the lines with backslash it won't introduce newlines. – vacawama Feb 24 '18 at 18:22
@vacawama whoa… I didn't know that. That's awesome. – Rob Napier Feb 24 '18 at 18:25
1

Disabling linting rules is never a good solution. If you start doing that, there is no point in having a linter in the first place. The root problem is the fact that localization tools want you to use the default message as the localization key. There is no point in putting the whole message in code, a simple string code, e.g. "sign_in_info' would work too. – Sulthan Feb 24 '18 at 18:34
I disagree that disabling linting rules is never a good solution. If that were true, they would be compiler errors. The fact that we separate even warnings from linting is intentional. Linting is intentionally over-strict. Even Go, where things as benign as failure to use a variable is a compile-time error, there is still a linter (govet) that is sometimes correct to ignore. The correct choice between shortened localization keys versus using automated tools has no universal answer. Saying "the linter forbids using Apple's localization tools" is a foolish consistency. – Rob Napier Feb 24 '18 at 19:07
2

(I say this as a long-time advocate for there being a "1 true Swift style" such that clang-format would enforce exactly one way lay out Swift code. Even if I'd had my way, there would be times to ignore a linter. http://openradar.appspot.com/radar?id=5886836526284800) – Rob Napier Feb 24 '18 at 19:10
`// swiftlint:disable:next line_length` is the answer we found best – Yatko Mar 14 '18 at 22:41

score 30 · Answer 2 · edited Dec 19 '18 at 14:01

30

In this case just update your line_length rule with ignores_interpolated_strings like this:

line_length:
  warning: 120
  ignores_function_declarations: true
  ignores_comments: true
  ignores_interpolated_strings: true
  ignores_urls: true

and make sure you are using last version of swiftlint (it was added just a few weeks ago)

edited Dec 19 '18 at 14:01

ethanhuang13

483
5
13

answered May 21 '18 at 01:35

Ilya Ilin

2,283
21
27

Not ignoring comments. – Soumen Jul 29 '18 at 05:56
3

it's not working :( it try to put the same in .yml file and again same warning still appear only the following is working so far line_length: 200 which i don't want for all line – Amr Angry Mar 06 '19 at 08:17
warning is not going by ignores_interpolated_strings this thing – Pravin Tate Sep 25 '20 at 14:00
1

Still not working – Aesop Jan 11 '22 at 18:43
Where i can find this file .swiftlint.yml? I have installed through brew commands, will this in be my project folder as hidden? – – karthikeyan Oct 27 '22 at 13:57

score 4 · Answer 3 · answered Apr 30 '20 at 03:56

4

This line added in .swiftlint.yml rule file its works for me

# implicitly 
line_length: 110

answered Apr 30 '20 at 03:56

kishor soneji

795
1
9
16

Where i can find this file .swiftlint.yml? I have installed through brew commands, will this in be my project folder as hidden? – – karthikeyan Oct 27 '22 at 13:57

How to fix 'Line Length Violation: Line should be 120 characters or less' - SwiftLint

3 Answers3

Linked