Error in if statement

Question

I have an android app. in that I am comparing two strings from the EditTest, but I get some strange results...

if(v==findViewById(R.id.submit)){
            //

            if(email==crfm_email)
            {

                String warn="Done!";
                Toast toast = Toast.makeText(getBaseContext(), warn, Toast.LENGTH_LONG);
                toast.show();
            }
            else
            {
                oFN=(EditText)findViewById(R.id.owners_first_name);
                String warn="email addresses do not match "+eMail+" "+crfEmail;
                Toast toast = Toast.makeText(getBaseContext(), warn, Toast.LENGTH_LONG);
                toast.show();

            }

        }

the problem is that the control always goes to the else part even if the input for both variables are same. I know that its a simple mistake but cant crack it out...!

thanks why is this comment" "if" is not a loop.!!!! – radkrish"? — rahul, Feb 04 '11 at 13:25
Iam confused..because I have more than one answer for this question and all are similar..which one to be accepted..the first responce..? — rahul, Feb 04 '11 at 13:26

score 3 · Answer 1 · answered Feb 04 '11 at 13:13

3

Use:

if (email.equals(crfm_email))
{
    ....

to compare the strings. The point being you want to compare the contents of the Strings, not the references to the String objects.

answered Feb 04 '11 at 13:13

trojanfoe

120,358
21
212
242

score 2 · Accepted Answer · answered Feb 04 '11 at 13:12

2

Looks like you are doing an object ref compare instead of an object compare.

if(email==crfm_email)

Should probably be...

if(email.equals(crfm_email))

answered Feb 04 '11 at 13:12

Andrew White

52,720
19
113
137

score 2 · Answer 3 · answered Feb 04 '11 at 13:13

2

Try :

email.equals(crfm_email)

== in java compares if it is the same instance of the string not if the content of the string are the same

answered Feb 04 '11 at 13:13

Yahel

8,522
2
24
32

score 0 · Answer 4 · edited May 23 '17 at 10:33

0

I think you might be interested in the following SO question: Java common Gotcha's.

Top contender is using == in stead of equals :)

edited May 23 '17 at 10:33

Community

1
1

answered Feb 04 '11 at 13:19

extraneon

23,575
2
47
51

Error in if statement

4 Answers4