How to avoid Switch case on input values

Question

I asked myself a question to optimize my code in JavaScript. I am currently doing something like this :

Data.json :

{
  "House" :
    { "bedroom"  : "4" }
    { "kitchen"  : "1" }
    { "bathroom" : "2" }
}

Choose.js :

var Data = require('./Data.json');

printData = function(id) {
  console.log(getData(id));
}

getData = function(id) {
  switch (id) {
    case "bedroom":
      return Data.House.bedroom;
    case "kitchen":
      return Data.House.kitchen;
    case "bathroom":
      return Data.House.bathroom;
    default:
      break;
  }
}

And I would like to know if we could optimize this with a special syntax, for example if we simply have :

var Data = require('./Data.json');

printData = function(id) {
  console.log(Data.House.{ id });
}

I know this might be a stupid question for you but it would be helpful if you tell me if it's possible or not. I wish I could avoid very long Switch Cases in my project.

Thanks.

score 3 · Accepted Answer · answered Apr 23 '18 at 13:00

3

Use [] notation

printData=function(id){
    return Data.House[id];
}

answered Apr 23 '18 at 13:00

gurvinder372

66,980
10
72
94

Faly · Answer 2 · 2018-04-23T13:05:31.157

1

You can do it:

var Data = {
  "House" : { 
    "bedroom"  : "4", 
    "kitchen"  : "1",
    "bathroom" : "2" 
  }
};

getData = function(id) {
  return Data.House[id];
}

console.log(getData('bedroom'));
console.log(getData('kitchen'));
console.log(getData('xxx'));

edited Apr 23 '18 at 13:05

answered Apr 23 '18 at 13:00

Faly

13,291
2
19
37

score 1 · Answer 3 · answered Apr 23 '18 at 13:01

1

getData=function(id){
   if(Data.House.hasOwnProperty(id)) return Data.House[id];
    return '';
}

answered Apr 23 '18 at 13:01

LellisMoon

4,810
2
12
24

How to avoid Switch case on input values

3 Answers3