Update value JSON file using php

Question

Hello I'm trying to update a JSON file using PHP but it isn't working as I expect, can you try to correct it? I want change "gfdhdfghdfh" to "google.es" I added the index.php with all code because the script "update.php" is not posting. update.php:

<?php
var_dump($_POST);
$jsonContents = file_get_contents('js/json.json');
$name = $_POST['edit-name'];
$url = $_POST['edit-name1'];
$data = json_decode($jsonContents, true);
foreach ($data as $key => $value) {
    if ($value['name'] == $name) {
        $data[$key]['url'] == $url;
    }
};
$json = json_encode($data);
file_put_contents('js/json.json', $json);

?>

It takes the values from 2 boxes of the html code. (Name and Url)

JSON FILE:

[{"name":"gfdhdfghdfg","url":"gfdhdfghdfh"}]

index.php:

<?php
//ADD Links
if ($_SERVER['REQUEST_METHOD'] === 'POST') {

    var_dump($_POST);

    $jsonContents = file_get_contents('js/json.json');
    $name = $_POST['addname'];
    $url = $_POST['addlink'];
    $data = json_decode($jsonContents, true);
    $data[] = array(
        'name' => $name,
        'url' => $url
    );
    $json = json_encode($data);
    file_put_contents('js/json.json', $json);
    header('Location: http://URL/index.php');
}
?>
<!DOCTYPE html>
<html>

<head>
    <title>SSL Checker</title>
    <link rel="stylesheet" type="text/css" href="css/style.css">
    <link rel="icon" type="image/png" href="security-ssl.png"/>
    <script type="text/javascript" charset="utf-8">
        var Checker = <?php echo file_get_contents('js/json.json'); ?>;
    </script>
    <script type="text/javascript" src="js/script.js"></script>

</head>
<body onLoad="start()">
    <div id="title">
        <h1>SSL Checker</h1>
    </div>
    <div id="data">
        <form method="POST" onsubmit="SSL.Add()">
            <input type="text" name="addname" id="add-name" placeholder="Name" />
            <input type="text" name="addlink" id="add-link" placeholder="Link" />
            <input type="submit" value="Add" />
        </form>
        <div id="edit" role="aria-hidden">
            <form action="update.php" method="POST" id="saveEdit">
                <input type="text" id="edit-name">
                <input type="text" id="edit-name1">
                <input type="submit" value="Edit" /> <a onclick="CloseInput()" aria-label="Close">&#10006;</a>
            </form>
        </div>
        <input type="text" id="dl">
        <p id="counter"></p>
    </div>
    <div id="table">

       <table style="overflow-x:auto;">
       <tr>
           <th>Sites:</th>
       </tr>
           <tbody id="urls">
        </table>

    </div>
</body>
</html>

What values does it currently have? What values should it have? — John Conde, May 24 '18 at 11:32
are you entering "gfdhdfghdfg" in edit-name and "google.es" in edit-name1? — nandal, May 24 '18 at 11:40
Assuming the post values are set correctly, the logic works fine once you've fixed the double-equals issue. See https://eval.in/1009254 — iainn, May 24 '18 at 11:41
@iainn What can I do for comprove if the post values are set correctly? because it don't work — Anthy, May 24 '18 at 11:43

delboy1978uk · Accepted Answer · 2018-05-24T12:10:47.903

1

You have a double equals in your if statement. Change it to one equals to assign a value.

$data[$key]['url'] == $url;

to

$data[$key]['url'] = $url;

UPDATE

Based on following pastes and comments, it's the form POST which isn't sending, because the form elements only have an id and not a name.

edited May 24 '18 at 12:10

answered May 24 '18 at 11:33

delboy1978uk

12,118
2
21
39

Thanks you but it didn't solve the problem to update the file :/ – Anthy May 24 '18 at 11:35
Okay I now see your JSON. But can you `var_dump($_POST)` please? – delboy1978uk May 24 '18 at 11:38
paste the content of var_dump($_POST) along with the question. – nandal May 24 '18 at 11:41
How can I see the content of var_dump? – Anthy May 24 '18 at 11:44
`var_dump($_POST); exit;` – delboy1978uk May 24 '18 at 11:45
Okey, it is the result: array(0) { } – Anthy May 24 '18 at 11:55
Ok, so your form never posted, therefore $value['name'] will never `==` gfdhdfghdfg – delboy1978uk May 24 '18 at 11:57
How can I solve it? I can send my html code if you want too – Anthy May 24 '18 at 11:58
I posted my "main page" index.php – Anthy May 24 '18 at 12:01
what is this? `onsubmit="SSL.Add()"` – delboy1978uk May 24 '18 at 12:03
Its for add links to the json file, but it works, now I'm doing the section to "edit" the json file – Anthy May 24 '18 at 12:03
it's stopping the $_POST – delboy1978uk May 24 '18 at 12:04
How can I compatibility the 2 process? – Anthy May 24 '18 at 12:05
I found the misstake there weren't "name" set on the imput name-edit, can you add it on your answer and I'll accept the answer as corret? – Anthy May 24 '18 at 12:08

Update value JSON file using php

1 Answers1