Is it a bad practice to make methods in a Servlet Class?

Question

Let's say this is my MainController:

import javax.servlet.ServletException;
import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import javax.servlet.http.HttpSession;
import javax.websocket.Session;

public class MainController extends HttpServlet {

    protected void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
    request.getRequestDispatcher("/login.jsp").forward(request, response);
    }

    public void myMethod() {
         // my code
    }

}

If it is a bad practice, can you also explain why?

It is not bad practice. A servlet class is a class. The "servlet" aspect of it does not mean that its "class"/"unit of code" aspect doesn't apply. — ernest_k, Jun 20 '18 at 05:53
It is unlikely that it needs to be `public`, though. Where do you want to call it from? — Thilo, Jun 20 '18 at 05:54

score 1 · Accepted Answer · answered Jun 20 '18 at 05:56

Nothing stops you from doing so. It's all about the architecture you follow. In MVC, The model, view, and controller(servlets) are actually decoupled.

Tomorrow if there is a change in the business logic. Model(service to be more specific) is the only layer that would be affected and the other two components don't event care

This Decoupling helps you in writing complex applications(desktop and web both).

Coupling and cohesion is another fundamental aspect that one should care(apart from DI IOC) while writing applications.

Is it a bad practice to make methods in a Servlet Class?

1 Answers1