If variable=string always returns true

Asked Jul 04 '18 at 22:25

Active Nov 21 '18 at 02:21

Viewed 27 times

I am having trouble with my javascript.

function login() {
  var username = document.getElementById("username").value;
  var password = document.getElementById("password").value;
  var combine = (username + password)
  if (combine = "userpassword") 
    alert("Logged in.")
  } else {
      alert("Incorrect username or Password.")
  }
}

<!DOCTYPE HTML>
<html>
<body>
<form id="login" onsubmit="return false;">
Username:<br>
<input type="text" name="username" id="username"><br>
Password:<br>
<input type="text" name="password" id="password"><br>
<input type="submit" type="POST" onclick="login();" />
</form>

As you can see, This is a login form. If i type it right, I get "Logged in." But if i type t wrong; I get the same message. Any suggestions would be appreciated.

This is not a duplicate, As this post describes my problem, and I would have no way of knowing that the other post had the answers to my problem.

edited Nov 21 '18 at 02:21

asked Jul 04 '18 at 22:25

Elijah R

1

`if (combine = "userpassword") ` should be `if (combine === "userpassword") ` – pmkro Jul 04 '18 at 22:26
Please [learn to love labels](http://www.456bereastreet.com/archive/200711/use_the_label_element_to_make_your_html_forms_accessible/) – Quentin Jul 04 '18 at 22:29
@PMKRO Thanks! If you posted that as an answer, I'd have checked it. – Elijah R Dec 29 '18 at 04:34

If variable=string always returns true

0 Answers0