PHP 7.2 - Warning: count(): Parameter must be an array or an object that implements Countable

Question

I just upgraded my PHP installation from version 5.6 to 7.2. I used the count() function on my login page like so:

if (!empty($_POST['username']) && !empty($_POST['password'])):
    $records = $conn->prepare('SELECT id,username,password FROM users WHERE username = :username');
    $records->bindParam(':username', $_POST['username']);
    $records->execute();
    $results = $records->fetch(PDO::FETCH_ASSOC);

    $message = '';
    
    if (count($results) > 0 && password_verify($_POST['password'], $results['password'])) {
        $_SESSION['user_id'] = $results['id'];
        header("Location: /");
    } else {
        $message = 'Sorry, those credentials do not match';
    }
endif;

After searching, I found questions and answers similar to this one, but they all were related to WordPress, and I couldn’t find a solution for Pure PHP.

I guess $results is not an array? Try checking it with bool is_array ( mixed $var ) before checking other stuff. — Dominik, Jul 30 '18 at 13:16
"**Pure PHP**" [count() will now yield a warning on invalid countable types passed to the array_or_countable parameter.](http://php.net/manual/en/function.count.php#refsect1-function.count-changelog) — MonkeyZeus, Jul 30 '18 at 13:16
I think the problem with "$results". can you update your question like, how you get data into $results variable? — Rajinder, Jul 30 '18 at 13:17
Dump `$results`: `var_dump($results)`. It will probably be returning a bool (false) as the query might have failed. — Script47, Jul 30 '18 at 13:19
check this thread https://stackoverflow.com/a/54806221/3016038 for php is_countable function — Vipul, Feb 21 '19 at 11:46
here is quick fix https://sdtuts.com/warning-count-parameter-must-be-an-array-or-an-object-that-implements-fixed/ even parameter not `array` — user3151197, Mar 17 '19 at 09:35

Olim Saidov · Accepted Answer · 2020-11-02T08:59:24.190

26

PDO fetch returns false on failure. So you need to check this case too:

if ($results && count($results) > 0 && password_verify($_POST['password'], $results['password'])) {
    $_SESSION['user_id'] = $results['id'];
    header("Location: /");
} else {
    $message = 'Sorry, those credentials do not match';
}

edited Nov 02 '20 at 08:59

answered Jul 30 '18 at 13:21

Olim Saidov

2,796
1
25
32

3

Not *'may return false on failure'*, it *will* return false on failure: '*The return value of this function on success depends on the fetch type. In all cases, FALSE is returned on failure.*' – Script47 Jul 30 '18 at 13:22
1

@Script47Thanks, updated accordingly. – Olim Saidov Jul 30 '18 at 13:25
you can use !is_null() to solve this issue. – Charvi May 28 '19 at 13:25
1

`count($results) > 0` is a needless/redundant check after `$results`, right? – mickmackusa Sep 27 '19 at 15:28
you can also use >> error_reporting( error_reporting() & ~E_WARNING ); to mak the warning silance – Amr Angry Sep 14 '20 at 13:05

PHP 7.2 - Warning: count(): Parameter must be an array or an object that implements Countable

1 Answers1

Linked

Related