Why do I get a runtime error: Vector erase iterator outside range

Question

I have faced with a strange runtime error for the following code:

#include <algorithm>
#include <vector>

using std::vector;

struct Data
{
    int id;
};

int main()
{
    vector<Data> mylist;

    Data m;
    m.id = 10;

    mylist.push_back(m);

    mylist.erase(std::remove_if(
        mylist.begin(),
        mylist.end(),
        [](const Data &m) {
        return m.id>100;
    }));

    return 0;
}

The error says:

Vector erase iterator outside range

I am not after solving the problem like Ref1, Ref2 but realizing the cause of the problem and whether I have done something wrong.

@HenriMenke, I have fixed the MWE to create the same error. – Danze Aug 17 '18 at 04:48 — Danze, Aug 17 '18 at 04:48
Alright, I converted my downvote into an upvote :) – Henri Menke Aug 17 '18 at 05:28 — Henri Menke, Aug 17 '18 at 05:28

score 5 · Accepted Answer · answered Aug 17 '18 at 05:15

5

The correct form is

mylist.erase(
    std::remove_if(mylist.begin(),mylist.end(),lambda),
    mylist.end());

You need to pass the end to the erase too.

answered Aug 17 '18 at 05:15

Arash

2,114
11
16

score 2 · Answer 2 · answered Aug 17 '18 at 05:15

In the above example, the remove_if function template will return an invalid iterator. Now as per the documentation of std::vector::erase the iterator pos must be valid and dereferenceable which is in your case is not valid and because of which the assert message is thrown.

Alternatively, you can just provide the end() iterator as second argument to the std::vector::erase function or use std::vector::pop_back to pop the element from the vector.

Why do I get a runtime error: Vector erase iterator outside range

2 Answers2