How to fix Undefined variable: request in laravel 5.6

Question

I am going to filter data with districtname in my vehicles table like this,

public function index()
    {
       $vehicles = Vehicle::with('uploads')
                ->when($request->district, function ($query, $request) {
                    return $query->where('districtname', $request->district);
                })->get();

        return view('vehicles.index')->withVehicles($vehicles);
    }

and my vehicle table like this,

id  districtname  vehiclename 
1    alabama          toyota
2    alamaba          ford
3    miyuri           bmw
4    misisipi         benz
5    miyuri           ford
6    alabama          toyota

and routes is like this,

Route::get('district', [
    'uses' => 'VehicleController@index',
    'as'   => 'districts.index',

]);

but got following error msg,

Undefined variable: request
in VehicleController.php line 39

how can fix this???

Possible duplicate of ["Notice: Undefined variable", "Notice: Undefined index", and "Notice: Undefined offset" using PHP](https://stackoverflow.com/questions/4261133/notice-undefined-variable-notice-undefined-index-and-notice-undefined) — Qirel, Sep 01 '18 at 08:06
The `$request` variable is not visible inside the index method, you don't pass an argument with that name. — Qirel, Sep 01 '18 at 08:07
then got **Missing argument 1 for App\Http\Controllers\VehicleController::index()** err msg — banda, Sep 01 '18 at 08:12
You must be pass param in `public function index(Request $request) {}`. Be remember to add `Request` namespace [check](https://laravel.com/docs/5.6/requests). — Jaydeep Mor, Sep 01 '18 at 08:20
Possible duplicate of [Reference - What does this error mean in PHP?](https://stackoverflow.com/questions/12769982/reference-what-does-this-error-mean-in-php) — Shadow, Sep 01 '18 at 08:33
did public function index(Request $request) {} but got **Trying to get property of non-object** — banda, Sep 01 '18 at 09:38

score 1 · Answer 1 · answered Sep 01 '18 at 12:20

1

When you call when() on the query builder, the first argument is the value you want to pass to the callback, that is passed as the second argument.

When you do

->when($request->district, function ($query, $request) {
  return $query->where('districtname', $request->district);
})

then $request->district is passed to the callback, provided it has a value, therefore there is no need to try to access its district property.

To fix that, change the above to:

->when($request->district, function ($query, $district) {
  return $query->where('districtname', $district);
})

answered Sep 01 '18 at 12:20

jedrzej.kurylo

39,591
9
98
107

Which model do you want to filter by district name? Vehicles? Uploads? – jedrzej.kurylo Sep 01 '18 at 15:23
Could you dump $request->district and make sure it contains correct value? – jedrzej.kurylo Sep 01 '18 at 15:24
I need filter districtname from vehicles table. and I did dd($request->district); it is printing district name... – banda Sep 01 '18 at 15:34
Could you replace ->get() with ->toSql() and ->getBindings() and paste the results here? This will get us the query that is being run – jedrzej.kurylo Sep 02 '18 at 04:36

score 0 · Answer 2 · answered Sep 01 '18 at 12:51

The error

Undefined variable: request
in VehicleController.php line 39

Is because of not using REQUEST in the function index

You will have to use Illuminate\Http\Request in your class as well as you will need to pass the REQUEST obj in your index function.

Check the below code to use it.

namespace App\Http\Controllers;

use Illuminate\Http\Request;

class SomeController extends Controller
{

    public function index(Request $request)
    {
       $vehicles = Vehicle::with('uploads')
                ->when($request->district, function ($query, $district) {
                    return $query->where('districtname', $district);
                })->get();

        return view('vehicles.index')->withVehicles($vehicles);
    }

}

How to fix Undefined variable: request in laravel 5.6

2 Answers2