PHP - foreach returning duplicate entries

Question

I have a foreach loop returning duplicate entries from a array string without duplicates inside it.

The code:

$a = [];
        $b = [];
        foreach($categories['results'][0]['parameters'] as $key => $value) {
            if(in_array($value['code'], $input_valid_names)) {
                if($value['type'] == 'input') {
                    $a = $value['code'];
                    $b = $PostData[$value['code']];
                }
                if($value['type'] == 'select'){
                    $a = $value['code'];
                    $b = $PostData[$value['code']];
                }
                if($value['type'] == 'checkbox' && !empty($PostData[$value['code']])){
                    $a = $value['code'];
                    $b = 'Sim';
                }
                $param[] = [$a => $b];
            }
        }

Any idea why its doing it? Made several debug but no clue...

Can you show the result of `var_dump($param[])`? (you can edit your question) — Ronnie Oosting, Sep 13 '18 at 09:34
Well there is a difference between both you can check https://stackoverflow.com/questions/80646/how-do-the-php-equality-double-equals-and-identity-triple-equals-comp — Exterminator, Sep 13 '18 at 09:56
I know the difference but here no mismatch here clearly known that we are matching `string` and `string` @Exterminator BTW i was reading the same post when you commented about that post hihihihihi — Er. Amit Joshi, Sep 13 '18 at 10:00

Dmytro Huz · Accepted Answer · 2018-09-13T09:55:20.573

Because when $value['type'] not equal for any if statement your code sets in $param previous $a/$b value. Try this:

    $param = [];
    foreach($categories['results'][0]['parameters'] as $key => $value) {
        $a = false;
        $b = false;
        if(in_array($value['code'], $input_valid_names)) {
            if($value['type'] == 'input') {
                $a = $value['code'];
                $b = $PostData[$value['code']];
            }
            if($value['type'] == 'select'){
                $a = $value['code'];
                $b = $PostData[$value['code']];
            }
            if($value['type'] == 'checkbox' && !empty($PostData[$value['code']])){
                $a = $value['code'];
                $b = 'Sim';
            }
            if($a and $b){
                $param[] = [$a => $b];
            }
        }
    }

score 0 · Answer 2 · answered Sep 13 '18 at 09:40

$a = '';
    $b = '';
    $param = array();
    foreach ($categories['results'][0]['parameters'] as $key => $value) {
        if (in_array($value['code'], $input_valid_names)) {
            if ($value['type'] === 'input') {
                $a = $value['code'];
                $b = $PostData[$value['code']];
            }else if ($value['type'] === 'select') {
                $a = $value['code'];
                $b = $PostData[$value['code']];
            }else if ($value['type'] === 'checkbox' && !empty($PostData[$value['code']])) {
                $a = $value['code'];
                $b = 'Sim';
            }
            $param[] = [$a => $b];
        }
    }

I think nothing will change because `value['type']== 'input'` and `value['type']==='input'` both are `TRUE` — Er. Amit Joshi, Sep 13 '18 at 09:47

score 0 · Answer 3 · answered Sep 13 '18 at 09:57

0

Solved it, putting:

$param[] = [$a => $b];

inside every if validation. No more duplicate values inside $param array.

answered Sep 13 '18 at 09:57

André Castro

1,527
6
33
60

You make not a necessary duplication of the code. check this and just copy this solution: https://stackoverflow.com/a/52311074/5907412 – Dmytro Huz Sep 13 '18 at 10:02
1

Hi Andre, it seems Dmytro answered your question. If that is the case you can delete your answer and accept his. – Ronnie Oosting Sep 13 '18 at 11:25
Many Thanks... Right answer checked :) – André Castro Sep 13 '18 at 20:35

PHP - foreach returning duplicate entries

3 Answers3