php data on crud doesn't inserted

Question

im making an insert function on php, everything is ok, there is no error but the data doesnt show up in the database, here is my php file

<?php 
include 'koneksi/koneksi.php';

if(isset($_POST['Submit'])) {
    $id_koperasi = $_POST['id'];
    $nama_koperasi = $_POST['nama'];
    $alamat = $_POST['alamat'];
    $telp = $_POST['telp'];
    $hp = $_POST['hp'];
    $nama_cp = $_POST['kontak'];
    $email = $_POST['email'];
    $nama_cp = $_POST['kontak'];
    $tanggal = $_POST['tgl'];
    $ket_fu = $_POST['ket'];
    $hasil_pembahasan = $_POST['hasil'];
    $status = $_POST['stat'];


    $query = "INSERT INTO t_koperasi(id,id_koperasi,nama_koperasi,alamat,telp,hp,nama_cp,email,tanggal_fu,ket_fu,hasil_pembahasan,status) VALUES ('',
            '$id_koperasi',
            '$nama_koperasi',
            '$alamat',
            '$telp',
            '$hp',
            '$nama_cp',
            '$tanggal',
            '$ket_fu',
            '$hasil_pembahasan',
            '$status')"
    ;

    if (mysqli_query($con,$query)) {
        header("location:index.php");
    }else {
        error_log( "This code has errors!" );

    }
}

include 'views/v_form.php';

?>

and this is my database t_koperasi structure

Your code is open to [SQL injection](https://stackoverflow.com/q/332365/2469308) related attacks. Please learn to use [Prepared Statements](https://stackoverflow.com/questions/60174/how-can-i-prevent-sql-injection-in-php) — Madhur Bhaiya, Oct 07 '18 at 06:41
And how are you passing the $con object to this file. You need to pass it via some function parameter. — Madhur Bhaiya, Oct 07 '18 at 06:45
Objects donot get passed by just including a file. You need to wrap this into a class, and using proper functions to pass objects around. — Madhur Bhaiya, Oct 07 '18 at 06:50
If `id` is an autoincrement field, it would normally be missed out of the INSERT to make it assign the next value. — Nigel Ren, Oct 07 '18 at 06:51
i already used the including file method before and it works, i really didnt know what is happening — , Oct 07 '18 at 06:52
i tried delete the id on the php and it still doesnt work, if i dont put the id on the php file it will just give me error on the column — , Oct 07 '18 at 06:53
What error? It is useful to include some error text to see what is going wrong rather than just guessing. — Nigel Ren, Oct 07 '18 at 06:54
that is what happening when i doesnt put the id on the php file on values — , Oct 07 '18 at 06:55
Did you also remove the value in `VALUES ('',` - this `''` value needs to be removed. — Nigel Ren, Oct 07 '18 at 06:56
oh... i know what is happening, i forgot to put the email on php file, thank you guys — , Oct 07 '18 at 06:57

score 2 · Answer 1 · answered Oct 07 '18 at 07:05

2

The id is auto increasing, so you should remove id column in you insert sql. Also, the method you are using is dangerous, you should not totally trust what pass to you by other users in you website page, instead, you need to add filter functions.

answered Oct 07 '18 at 07:05

yusher

226
1
5

score 0 · Answer 2 · answered Oct 07 '18 at 09:37

You Query Should Look Like this. At Least in postgresql and MySql

$query = "INSERT INTO t_koperasi(id_koperasi,nama_koperasi,alamat,telp,hp,nama_cp,email,tanggal_fu,ket_fu,hasil_pembahasan,status) VALUES (
        '".$id_koperasi."',
        '".$nama_koperasi."',
        '".$alamat."',
        '".$telp."',
        '".$hp."',
        '".$nama_cp."',
        '".$tanggal."',
        '".$ket_fu."',
        '".$hasil_pembahasan."',
        '".$status."')"
;

You do not need to insert value into ID .Because ID expected to be the primary key with default value (auto increment).

Hope This works for you!

score 0 · Answer 3 · answered Oct 07 '18 at 10:01

Simple remove id and ' ' . i hope work fine.

or

You just copy this code and past your project

<?php 
include 'koneksi/koneksi.php';

if(isset($_POST['Submit'])) {
$id_koperasi = $_POST['id'];
$nama_koperasi = $_POST['nama'];
$alamat = $_POST['alamat'];
$telp = $_POST['telp'];
$hp = $_POST['hp'];
$nama_cp = $_POST['kontak'];
$email = $_POST['email'];
$nama_cp = $_POST['kontak'];
$tanggal = $_POST['tgl'];
$ket_fu = $_POST['ket'];
$hasil_pembahasan = $_POST['hasil'];
$status = $_POST['stat'];


$query = "INSERT INTO t_koperasi(id_koperasi,nama_koperasi,alamat,telp,hp,nama_cp,email,tanggal_fu,ket_fu,hasil_pembahasan,status) VALUES ('$id_koperasi',
        '$nama_koperasi',
        '$alamat',
        '$telp',
        '$hp',
        '$nama_cp',
        '$tanggal',
        '$ket_fu',
        '$hasil_pembahasan',
        '$status')"
;

if (mysqli_query($con,$query)) {
    header("location:index.php");
}else {
    error_log( "This code has errors!" );

}
}  include 'views/v_form.php';

php data on crud doesn't inserted

3 Answers3